[RAM] Edits rule role visibility label #170075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
added
Feature:Alerting
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Pinging @elastic/response-ops (Team:ResponseOps) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
jcger
approved these changes
Nov 2, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 2, 2023
(cherry picked from commit cdc55d7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 2, 2023
# Backport This will backport the following commits from `main` to `8.11`: - [[RAM] Edits rule role visibility label (#170075)](#170075) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-02T15:00:23Z","message":"[RAM] Edits rule role visibility label (#170075)","sha":"cdc55d7ca95057cf35955defd1a654e8dfad89fe","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","ui-copy","backport:prev-minor","v8.12.0","v8.11.1"],"number":170075,"url":"https://github.com/elastic/kibana/pull/170075","mergeCommit":{"message":"[RAM] Edits rule role visibility label (#170075)","sha":"cdc55d7ca95057cf35955defd1a654e8dfad89fe"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170075","number":170075,"mergeCommit":{"message":"[RAM] Edits rule role visibility label (#170075)","sha":"cdc55d7ca95057cf35955defd1a654e8dfad89fe"}},{"branch":"8.11","label":"v8.11.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Lisa Cawley <[email protected]>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #166032
This PR removes "Select" from "Select role visibility" since it's redundant and looks odd after you've selected a value for that field.
TBD: IMO neither "scope" nor "visibility" make it clear what this affects. Should we add a tooltip as well?
Screenshots
Before
After