Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] fix cypress config to run all tests #169942

Merged
merged 1 commit into from
Oct 26, 2023
Merged

[Security Solution] fix cypress config to run all tests #169942

merged 1 commit into from
Oct 26, 2023

Conversation

maximpn
Copy link
Contributor

@maximpn maximpn commented Oct 26, 2023 •
edited by kibanamachine
Loading

Summary

Revert accidentally changed package.json in #169842 to run all Security Solution Cypress test suites.

@maximpn maximpn requested a review from jpdjere October 26, 2023 14:01
@maximpn maximpn self-assigned this Oct 26, 2023
@maximpn maximpn added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team v8.11.0 v8.12.0 labels Oct 26, 2023
@maximpn maximpn marked this pull request as ready for review October 26, 2023 14:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@maximpn maximpn enabled auto-merge (squash) October 26, 2023 14:05
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Cypress Tests #1 / Enrichment Custom query rule from new risk scores Should has enrichment fields from legacy risk Should has enrichment fields from legacy risk

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maximpn

@maximpn maximpn merged commit 1f6090c into elastic:main Oct 26, 2023
13 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.11 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.11:
- [Security Solution] Adding serverlessQA tag (#167494)

Manual backport

To create the backport manually run:

node scripts/backport --pr 169942

Questions ?

Please refer to the Backport tool documentation

@maximpn maximpn deleted the fix-cypress-config branch October 26, 2023 16:20
@maximpn maximpn mentioned this pull request Oct 26, 2023
Closed
@maximpn
Copy link
Contributor Author

maximpn commented Oct 26, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

maximpn added a commit to maximpn/kibana that referenced this pull request Oct 26, 2023
@maximpn
[Security Solution] fix cypress config to run all tests (elastic#169942)
9a81d6e 
Revert accidentally changed `package.json` in elastic#169842 to run all Security Solution Cypress test suites.

(cherry picked from commit 1f6090c)
This was referenced Nov 3, 2023
Merged
Merged
This was referenced Nov 28, 2023
Merged
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 17, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 169942 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 169942 locally

@maximpn maximpn removed the v8.11.0 label Jun 21, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 169942 locally

@maximpn maximpn added the backport:skip This commit does not require backporting label Jun 25, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpdjere jpdjere jpdjere approved these changes

Assignees

@maximpn maximpn

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maximpn @elasticmachine @kibana-ci @kibanamachine @jpdjere