Eui dashboard listing #16967
Merged
Eui dashboard listing #16967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💔 Build Failed |
nreese
force-pushed
the
euiDashboardListing
branch
from
4fdfc50 to
80264ab
Compare
💔 Build Failed |
💔 Build Failed |
nreese
force-pushed
the
euiDashboardListing
branch
from
69f3f0f to
1b80508
Compare
💔 Build Failed |
💔 Build Failed |
nreese
force-pushed
the
euiDashboardListing
branch
from
c16a081 to
a706b00
Compare
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
nreese
force-pushed
the
euiDashboardListing
branch
from
f22d3b7 to
25230f9
Compare
💔 Build Failed |
|
jenkins, test this |
💔 Build Failed |
nreese
force-pushed
the
euiDashboardListing
branch
from
25230f9 to
759fdec
Compare
💔 Build Failed |
|
This PR is finally ready for review. The functional tests are failing because EuiSearchBox input can get out of sync. For example, typing |
|
I get a couple console warnings when I first load up the page: |
nreese
force-pushed
the
euiDashboardListing
branch
from
d640c9c to
0518ead
Compare
|
@stacey-gammon I have rebased this PR and it should be good for a final look. |
💔 Build Failed |
💚 Build Succeeded |
stacey-gammon
approved these changes
Apr 25, 2018
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Apr 26, 2018
* convert dashboard listing page to react and EUI * add jest test for DashboardListing component * add data-test-subj attributes * clean up jest test * hideWriteControls and call to action when no dashboards exist * pass initial filter to dashboard listing, get functional tests to work * fix dashboard queries functional tests * upgraded to EUI 0.0.29 to get defaultFocusedButton fix * move dashboardListing directive to index * spacing in if statement * switch to EuiBasicTable * pagination * add sorting * fix jest test * handle out of order fetchs * remove info.gif * re-instate search functional test * replace EuiSearchBar with EuiFieldSearch * fix functional tests * update snapshot - when code rebased - new EUI version add another prop * add Edit link to actions column
nreese
added a commit
that referenced
this pull request
Apr 26, 2018
* convert dashboard listing page to react and EUI * add jest test for DashboardListing component * add data-test-subj attributes * clean up jest test * hideWriteControls and call to action when no dashboards exist * pass initial filter to dashboard listing, get functional tests to work * fix dashboard queries functional tests * upgraded to EUI 0.0.29 to get defaultFocusedButton fix * move dashboardListing directive to index * spacing in if statement * switch to EuiBasicTable * pagination * add sorting * fix jest test * handle out of order fetchs * remove info.gif * re-instate search functional test * replace EuiSearchBar with EuiFieldSearch * fix functional tests * update snapshot - when code rebased - new EUI version add another prop * add Edit link to actions column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert dashboard listing page to react and EUI