Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure ESLint that should only work on TSX are set to only trigger on TSX files #169361

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented Oct 19, 2023

Summary

This makes the newly created i18n ESLint rule actually activate on paths, and narrows the use of the Telemetry ESLint rule to only activate on .tsx files. This is done because the rule only makes sense in the context of JSX.

More words

Noticed that this:

        'x-pack/plugins/aiops/**/*.{tsx}',
        'x-pack/plugins/apm/**/*.{tsx}',
        'x-pack/plugins/exploratory_view/**/*.{tsx}',

does not work.

This:

        'x-pack/plugins/aiops/**/*.tsx',
        'x-pack/plugins/apm/**/*.tsx',
        'x-pack/plugins/exploratory_view/**/*.tsx',

does.

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer changed the title Make sure ESLint that should only work on TSX are set to only trigger… Make sure ESLint that should only work on TSX are set to only trigger on TSX files Oct 19, 2023
@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label Oct 19, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 19, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #18 / Actions and Triggers app Connectors Opsgenie connector page should disable the run button when the message field is not filled

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit 7676cc4 into elastic:main Oct 19, 2023
3 checks passed
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants