-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Serverless] Implements panelContentProvider on the DefaultNavigation #169270
[Security Solution][Serverless] Implements panelContentProvider on the DefaultNavigation #169270
Conversation
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with feature on and off, both looked fine, LGTM!
@elasticmachine merge upstream |
@elasticmachine merge upstream |
…ation_panels_intergation
@elasticmachine merge upstream |
merge conflict between base and head |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @semd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to chrome service mock LGTM 👍
Summary
Implements the
panelContentProvider
for theDefaultNavigation
component, so the content of the panels when open is provided by the Security Solution plugin.In order to test it, the experimental flag needs to be enabled.
In
config/serverless.security.yml
add:Screenshot
(The vertical separation of the main nav links is still not implemented by the DefaultNavigation)