Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Serverless] Implements panelContentProvider on the DefaultNavigation #169270

Merged
merged 11 commits into from
Oct 23, 2023

Conversation

semd
Copy link
Contributor

@semd semd commented Oct 18, 2023

Summary

Implements the panelContentProvider for the DefaultNavigation component, so the content of the panels when open is provided by the Security Solution plugin.

In order to test it, the experimental flag needs to be enabled.
In config/serverless.security.yml add:

xpack.securitySolutionServerless.enableExperimental: ['platformNavEnabled']

Screenshot

Captura de pantalla 2023-10-18 a les 18 38 04

(The vertical separation of the main nav links is still not implemented by the DefaultNavigation)

@semd semd added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore v8.12.0 labels Oct 18, 2023
@semd semd self-assigned this Oct 18, 2023
@semd semd requested review from a team as code owners October 18, 2023 16:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@semd semd requested a review from sebelga October 19, 2023 09:11
Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with feature on and off, both looked fine, LGTM!

@semd
Copy link
Contributor Author

semd commented Oct 19, 2023

@elasticmachine merge upstream

@semd
Copy link
Contributor Author

semd commented Oct 19, 2023

@elasticmachine merge upstream

@kibanamachine kibanamachine requested a review from a team as a code owner October 19, 2023 17:09
@semd
Copy link
Contributor Author

semd commented Oct 20, 2023

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@semd semd removed the request for review from a team October 20, 2023 07:54
@semd
Copy link
Contributor Author

semd commented Oct 22, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolutionServerless 476 478 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.0MB 13.0MB +145.0B
securitySolutionServerless 332.9KB 333.2KB +327.0B
total +472.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolutionServerless 41.8KB 39.3KB -2.5KB
Unknown metric groups

async chunk count

id before after diff
securitySolutionServerless 42 43 +1

ESLint disabled line counts

id before after diff
securitySolutionServerless 35 36 +1

Total ESLint disabled count

id before after diff
securitySolutionServerless 35 36 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to chrome service mock LGTM 👍

@semd semd merged commit a8a22c3 into elastic:main Oct 23, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants