Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.10] [ResponseOps] Allow bulk snoozing of Security Rules (#169180) #169264

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.10:

Questions ?

Please refer to the Backport tool documentation

Fixes: elastic#169131

## Summary

Bulk snoozing of SIEM (Security Rules) was previously silently skipped
in the Rules Client when bulk editing rules to snooze scheduling a rule.

Since then, the snoozing functionality was introduced in the Security
Solution, but the check that silently skipped this update was never
removed in the Rules Client side.

The issue was only noticeable when bulk editing Rules to add snoozing in
the **Alerts and Insights > Rules** page, since Security Solution
doesn't allow bulk snoozing (as of yet) and all other areas of the UI do
not use bulk but single snoozing.

Removing the check to skip SIEM rules sufficed to fix the issue.

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 2f80ca2)
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.5MB 1.5MB -26.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
alerting 88 86 -2

Total ESLint disabled count

id before after diff
alerting 90 88 -2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jpdjere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants