Fixes issue with removing spaces from related objects in share to space action #169177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeramysoucy
added
Team:Security
…-ref HEAD~1..HEAD --fix'
|
Pinging @elastic/kibana-security (Team:Security) |
thomheymann
requested changes
Oct 19, 2023
...ins/spaces/public/share_saved_objects_to_space/components/share_to_space_flyout_internal.tsx
Outdated
Show resolved
Hide resolved
…-ref HEAD~1..HEAD --fix'
…-ref HEAD~1..HEAD --fix'
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
thomheymann
approved these changes
Oct 19, 2023
teresaalvarezsoler
approved these changes
Oct 23, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 23, 2023
…ce action (elastic#169177) closes elastic#168657 ## Summary Updates the `share to spaces` action to refrain from removing spaces from related objects (objects referenced by the target object). I have also updated the description of issue elastic#130562, which essentially will replace much of the client-side implementation of this action, to explicitly include this behavior. ### Manual Testing - Create 2 spaces: A and B - Add a sample data set (e.g. flight) to space A - In Discover, create a saved query called "s1" (add a filter that uses the sample data logs data view, and use the filter menu button) - Go to `Stack Management->Saved` Objects and share the "s1" query to space B - Verify that the related data view is also shared to space B. - Un-share the "s1" query from space B - Verify that the related data view is still shared to space B. ### Automated Tests - x-pack/plugins/spaces/public/share_saved_objects_to_space/components/share_to_space_flyout_internal.test.tsx --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 4af9175)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 23, 2023
… to space action (#169177) (#169566) # Backport This will backport the following commits from `main` to `8.11`: - [Fixes issue with removing spaces from related objects in share to space action (#169177)](#169177) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jeramy Soucy","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-23T18:45:36Z","message":"Fixes issue with removing spaces from related objects in share to space action (#169177)\n\ncloses #168657\r\n\r\n## Summary\r\n\r\nUpdates the `share to spaces` action to refrain from removing spaces\r\nfrom related objects (objects referenced by the target object).\r\n\r\nI have also updated the description of issue #130562, which essentially\r\nwill replace much of the client-side implementation of this action, to\r\nexplicitly include this behavior.\r\n\r\n### Manual Testing\r\n- Create 2 spaces: A and B\r\n- Add a sample data set (e.g. flight) to space A\r\n- In Discover, create a saved query called \"s1\" (add a filter that uses\r\nthe sample data logs data view, and use the filter menu button)\r\n- Go to `Stack Management->Saved` Objects and share the \"s1\" query to\r\nspace B\r\n- Verify that the related data view is also shared to space B.\r\n- Un-share the \"s1\" query from space B\r\n- Verify that the related data view is still shared to space B.\r\n\r\n### Automated Tests\r\n-\r\nx-pack/plugins/spaces/public/share_saved_objects_to_space/components/share_to_space_flyout_internal.test.tsx\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"4af91754e02e1f055d4912b298fd0f7d68740b74","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","backport:prev-minor","v8.11.0","v8.12.0"],"number":169177,"url":"https://github.com/elastic/kibana/pull/169177","mergeCommit":{"message":"Fixes issue with removing spaces from related objects in share to space action (#169177)\n\ncloses #168657\r\n\r\n## Summary\r\n\r\nUpdates the `share to spaces` action to refrain from removing spaces\r\nfrom related objects (objects referenced by the target object).\r\n\r\nI have also updated the description of issue #130562, which essentially\r\nwill replace much of the client-side implementation of this action, to\r\nexplicitly include this behavior.\r\n\r\n### Manual Testing\r\n- Create 2 spaces: A and B\r\n- Add a sample data set (e.g. flight) to space A\r\n- In Discover, create a saved query called \"s1\" (add a filter that uses\r\nthe sample data logs data view, and use the filter menu button)\r\n- Go to `Stack Management->Saved` Objects and share the \"s1\" query to\r\nspace B\r\n- Verify that the related data view is also shared to space B.\r\n- Un-share the \"s1\" query from space B\r\n- Verify that the related data view is still shared to space B.\r\n\r\n### Automated Tests\r\n-\r\nx-pack/plugins/spaces/public/share_saved_objects_to_space/components/share_to_space_flyout_internal.test.tsx\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"4af91754e02e1f055d4912b298fd0f7d68740b74"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169177","number":169177,"mergeCommit":{"message":"Fixes issue with removing spaces from related objects in share to space action (#169177)\n\ncloses #168657\r\n\r\n## Summary\r\n\r\nUpdates the `share to spaces` action to refrain from removing spaces\r\nfrom related objects (objects referenced by the target object).\r\n\r\nI have also updated the description of issue #130562, which essentially\r\nwill replace much of the client-side implementation of this action, to\r\nexplicitly include this behavior.\r\n\r\n### Manual Testing\r\n- Create 2 spaces: A and B\r\n- Add a sample data set (e.g. flight) to space A\r\n- In Discover, create a saved query called \"s1\" (add a filter that uses\r\nthe sample data logs data view, and use the filter menu button)\r\n- Go to `Stack Management->Saved` Objects and share the \"s1\" query to\r\nspace B\r\n- Verify that the related data view is also shared to space B.\r\n- Un-share the \"s1\" query from space B\r\n- Verify that the related data view is still shared to space B.\r\n\r\n### Automated Tests\r\n-\r\nx-pack/plugins/spaces/public/share_saved_objects_to_space/components/share_to_space_flyout_internal.test.tsx\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"4af91754e02e1f055d4912b298fd0f7d68740b74"}}]}] BACKPORT--> Co-authored-by: Jeramy Soucy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #168657
Summary
Updates the
share to spacesaction to refrain from removing spaces from related objects (objects referenced by the target object).I have also updated the description of issue #130562, which essentially will replace much of the client-side implementation of this action, to explicitly include this behavior.
Manual Testing
Stack Management->SavedObjects and share the "s1" query to space BAutomated Tests