Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAM] fix Slack API proxy #169171

Merged
merged 3 commits into from
Oct 18, 2023
Merged

[RAM] fix Slack API proxy #169171

merged 3 commits into from
Oct 18, 2023

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Oct 17, 2023

Summary

FIX -> #168701

Checklist

@XavierM XavierM added release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.11.0 v8.12.0 v8.10.4 labels Oct 17, 2023
@XavierM XavierM requested a review from a team as a code owner October 17, 2023 20:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@XavierM XavierM enabled auto-merge (squash) October 18, 2023 15:09
@XavierM XavierM disabled auto-merge October 18, 2023 15:26
@XavierM XavierM enabled auto-merge (squash) October 18, 2023 15:53
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 18, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 7df3f96 into elastic:main Oct 18, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 18, 2023
## Summary

FIX -> elastic#168701

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 7df3f96)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.10 Backport failed because of merge conflicts
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 169171

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 18, 2023
# Backport

This will backport the following commits from `main` to `8.11`:
- [[RAM] fix Slack API proxy
(#169171)](#169171)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Xavier
Mouligneau","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-18T18:03:47Z","message":"[RAM]
fix Slack API proxy (#169171)\n\n## Summary\r\n\r\nFIX ->
https://github.com/elastic/kibana/issues/168701\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7df3f964ce31285162dd8bc7d3850691872d01d5","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","v8.11.0","v8.12.0","v8.10.4"],"number":169171,"url":"https://github.com/elastic/kibana/pull/169171","mergeCommit":{"message":"[RAM]
fix Slack API proxy (#169171)\n\n## Summary\r\n\r\nFIX ->
https://github.com/elastic/kibana/issues/168701\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7df3f964ce31285162dd8bc7d3850691872d01d5"}},"sourceBranch":"main","suggestedTargetBranches":["8.11","8.10"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169171","number":169171,"mergeCommit":{"message":"[RAM]
fix Slack API proxy (#169171)\n\n## Summary\r\n\r\nFIX ->
https://github.com/elastic/kibana/issues/168701\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7df3f964ce31285162dd8bc7d3850691872d01d5"}},{"branch":"8.10","label":"v8.10.4","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Xavier Mouligneau <[email protected]>
XavierM added a commit to XavierM/kibana that referenced this pull request Oct 18, 2023
FIX -> elastic#168701

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 7df3f96)
XavierM added a commit that referenced this pull request Oct 23, 2023
# Backport

This will backport the following commits from `main` to `8.11`:
- [[RAM] fix Slack API proxy
(#169171)](#169171)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Xavier
Mouligneau","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-18T18:03:47Z","message":"[RAM]
fix Slack API proxy (#169171)\n\n## Summary\r\n\r\nFIX ->
https://github.com/elastic/kibana/issues/168701\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7df3f964ce31285162dd8bc7d3850691872d01d5","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","v8.11.0","v8.12.0","v8.10.4"],"number":169171,"url":"https://github.com/elastic/kibana/pull/169171","mergeCommit":{"message":"[RAM]
fix Slack API proxy (#169171)\n\n## Summary\r\n\r\nFIX ->
https://github.com/elastic/kibana/issues/168701\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7df3f964ce31285162dd8bc7d3850691872d01d5"}},"sourceBranch":"main","suggestedTargetBranches":["8.11","8.10"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169171","number":169171,"mergeCommit":{"message":"[RAM]
fix Slack API proxy (#169171)\n\n## Summary\r\n\r\nFIX ->
https://github.com/elastic/kibana/issues/168701\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7df3f964ce31285162dd8bc7d3850691872d01d5"}},{"branch":"8.10","label":"v8.10.4","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.4 v8.10.5 v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants