Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security solution] Update serverless roles to include Data Views fea… #169036

Merged

Conversation

patrykkopycinski
Copy link
Contributor

…ture permissions

Summary

Align roles with project-controller

@patrykkopycinski patrykkopycinski marked this pull request as ready for review October 16, 2023 21:37
@patrykkopycinski patrykkopycinski requested review from a team as code owners October 16, 2023 21:37
@patrykkopycinski patrykkopycinski self-assigned this Oct 16, 2023
@patrykkopycinski patrykkopycinski added the release_note:skip Skip the PR/issue when compiling release notes label Oct 16, 2023
@@ -387,6 +387,7 @@ soc_manager:
- feature_actions.all
- feature_builtInAlerts.all
- feature_osquery.all
- feature_indexPatterns.all # Detections Data Views
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. I think you missed my prior comment. can you update line 8 of this file with this path instead:

x-pack/plugins/security_solution/scripts/endpoint/common/roles_users/serverless/es_serverless_resources/roles.yml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crap. never mind
this is the Kibana PR 🤦

Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link
Contributor

@dhurley14 dhurley14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@patrykkopycinski patrykkopycinski merged commit 4113d25 into elastic:main Oct 17, 2023
3 checks passed
@patrykkopycinski patrykkopycinski deleted the fix/detection-engine-init-role branch October 17, 2023 07:36
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Oct 17, 2023
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
elastic#169036)

…ture permissions

## Summary

Align roles with project-controller
@patrykkopycinski patrykkopycinski added v8.11.0 auto-backport Deprecated - use backport:version if exact versions are needed and removed backport:skip This commit does not require backporting labels Oct 24, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.11 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.11:
- [Security Solution] adds users + roles for security serverless projects to kibana (#168420)

Manual backport

To create the backport manually run:

node scripts/backport --pr 169036

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@ashokaditya
Copy link
Member

depends on #169763

@ashokaditya
Copy link
Member

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

ashokaditya pushed a commit to ashokaditya/kibana that referenced this pull request Oct 25, 2023
elastic#169036)

…ture permissions

## Summary

Align roles with project-controller

(cherry picked from commit 4113d25)

# Conflicts:
#	x-pack/plugins/security_solution/scripts/endpoint/common/roles_users/endpoint_operations_analyst.ts
ashokaditya added a commit that referenced this pull request Oct 26, 2023
…ews fea… (#169036) (#169784)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Security solution] Update serverless roles to include Data Views
fea… (#169036)](#169036)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Patryk
Kopyciński","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-17T07:36:07Z","message":"[Security
solution] Update serverless roles to include Data Views fea…
(#169036)\n\n…ture permissions\r\n\r\n## Summary\r\n\r\nAlign roles with
project-controller","sha":"4113d25f01ab22a704fda65f823113be34fd8757","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","auto-backport","v8.11.0","v8.12.0"],"number":169036,"url":"https://github.com/elastic/kibana/pull/169036","mergeCommit":{"message":"[Security
solution] Update serverless roles to include Data Views fea…
(#169036)\n\n…ture permissions\r\n\r\n## Summary\r\n\r\nAlign roles with
project-controller","sha":"4113d25f01ab22a704fda65f823113be34fd8757"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169036","number":169036,"mergeCommit":{"message":"[Security
solution] Update serverless roles to include Data Views fea…
(#169036)\n\n…ture permissions\r\n\r\n## Summary\r\n\r\nAlign roles with
project-controller","sha":"4113d25f01ab22a704fda65f823113be34fd8757"}}]}]
BACKPORT-->

Co-authored-by: Patryk Kopyciński <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants