Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security solution] Rename connector from AWS Bedrock to Amazon Bedrock #169025

Merged
merged 6 commits into from
Oct 17, 2023

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Oct 16, 2023

Summary

Resolves https://github.com/elastic/security-team/issues/7846

Renames AWS Bedrock to Amazon Bedrock

In stack management:
Screenshot 2023-10-16 at 1 57 37 PM

In security solution:
Screenshot 2023-10-16 at 1 56 54 PM

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.11.0 v8.12.0 v8.11.1 labels Oct 16, 2023
@stephmilovic stephmilovic requested review from a team as code owners October 16, 2023 19:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)


interface Props {
actionTypes?: ActionType[];
actionTypeRegistry: ActionTypeRegistryContract;
onClose: () => void;
onSelect: (actionType: ActionType) => void;
}
const itemClassName = css`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without the extra CSS:
Screenshot 2023-10-16 at 1 52 28 PM

white-space property puts it on one line and aligns the icons
Screenshot 2023-10-16 at 1 53 46 PM

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thanks @stephmilovic!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.0MB 13.0MB +580.0B
stackConnectors 515.6KB 515.6KB +15.0B
total +595.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
stackConnectors 38.3KB 38.3KB +6.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 17, 2023
kibanamachine added a commit that referenced this pull request Oct 17, 2023
…n Bedrock (#169025) (#169162)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Security solution] Rename connector from AWS Bedrock to Amazon
Bedrock (#169025)](#169025)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Steph
Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-17T18:24:03Z","message":"[Security
solution] Rename connector from AWS Bedrock to Amazon Bedrock
(#169025)","sha":"9b73b87d5c7d639c1798e5d8572af8d0c65ffd21","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:
SecuritySolution","v8.11.0","v8.12.0","v8.11.1"],"number":169025,"url":"https://github.com/elastic/kibana/pull/169025","mergeCommit":{"message":"[Security
solution] Rename connector from AWS Bedrock to Amazon Bedrock
(#169025)","sha":"9b73b87d5c7d639c1798e5d8572af8d0c65ffd21"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169025","number":169025,"mergeCommit":{"message":"[Security
solution] Rename connector from AWS Bedrock to Amazon Bedrock
(#169025)","sha":"9b73b87d5c7d639c1798e5d8572af8d0c65ffd21"}}]}]
BACKPORT-->

Co-authored-by: Steph Milovic <[email protected]>
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.11.0 v8.11.1 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants