Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Unskip shared links test #168923

Merged
merged 3 commits into from
Oct 18, 2023
Merged

[Discover] Unskip shared links test #168923

merged 3 commits into from
Oct 18, 2023

Conversation

kertal
Copy link
Member

@kertal kertal commented Oct 16, 2023 •
edited by kibanamachine
Loading

Summary

This PR improves and unskips Discover's shared links tests, and makes them a few seconds faster on top
Flaky test runner (100): https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3515

Resolves #167405

Checklist

@kertal kertal added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Oct 16, 2023
@kertal kertal self-assigned this Oct 16, 2023
@kertal kertal marked this pull request as ready for review October 16, 2023 14:04
@kertal kertal requested a review from a team as a code owner October 16, 2023 14:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 16, 2023
kertal
kertal commented Oct 16, 2023
View reviewed changes
test/functional/apps/discover/group1/_shared_links.ts
});
await PageObjects.timePicker.setDefaultAbsoluteRangeViaUiSettings();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting this time range by UISettings is always a bit faster than doing it via UI

kertal
kertal commented Oct 16, 2023
View reviewed changes
test/functional/apps/discover/group1/_shared_links.ts

// After hiding the time picker, we need to wait for
// the refresh button to hide before clicking the share button
await PageObjects.common.sleep(1000);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more reason to sleep!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

davismcphee
davismcphee approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing!

@kertal kertal merged commit 414b1da into elastic:main Oct 18, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.11 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 168923

Questions ?

Please refer to the Backport tool documentation

hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Oct 18, 2023
@kertal @hop-dev
[Discover] Unskip shared links test (elastic#168923)
2e367b2 
Improves and unskips Discover's shared links tests, and makes them a few seconds faster on top
Flaky test runner (100): https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3515
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 14, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 168923 locally

4 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 168923 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 168923 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 168923 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 168923 locally

@kertal kertal removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 27, 2024
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 30, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 168923 locally

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 168923 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 168923 locally

@jughosta
Copy link
Contributor

jughosta commented Apr 5, 2024

It's too late to backport to 8.11 now. I am adding backport:skip to stop reminders.

@jughosta jughosta added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Apr 5, 2024
@kertal
Copy link
Member Author

kertal commented Apr 5, 2024

@jughosta thx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

Assignees

@kertal kertal

Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.12.0
Projects
None yet
Milestone
No milestone
6 participants
@kertal @elasticmachine @kibana-ci @kibanamachine @jughosta @davismcphee