Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Entity Analytics]Integration test cleanup #168869

Merged
merged 4 commits into from
Nov 8, 2023
Merged

[Entity Analytics]Integration test cleanup #168869

merged 4 commits into from
Nov 8, 2023

Conversation

rylnd
Copy link
Contributor

@rylnd rylnd commented Oct 13, 2023

Summary

Followup to some recent work to improve test reliability (namely #168469):

  • Consolidates teardown of risk engine artifacts into a single helper function
  • Removes references to flaky test issues in comments
  • Log utils errors at the warning level

rylnd added 3 commits October 13, 2023 10:08
@rylnd
Log util errors as warnings
a9d8537 
When logged as errors, these distract from the results of the tests. In
things we call a lot, indiscriminately (like clearLegacyTransforms) this
causes a lot of noise.
@rylnd
Define and use our cleanup helper function
bf19b0c 
This simply consolidates a bunch of various "cleanup" functions that we
were calling inconsistently into a single function. It's meant to be
called before and after every test using the risk engine, which this
commit also does.
@rylnd
Remove references to flaky tests in comments
6996090 
These issues will get auto-reopened if/when the test fails again; until
they do, and the tests are manually/automatically skipped (at which
point they could have this reference manually/automatically added back),
these are just noise.
@rylnd rylnd added chore technical debt Improvement of the software architecture and operational architecture Theme: entity_analytics Feature:Entity Analytics Security Solution Entity Analytics features v8.12.0 labels Oct 13, 2023
@rylnd rylnd self-assigned this Oct 13, 2023
@rylnd rylnd requested a review from a team as a code owner October 13, 2023 15:52
@rylnd rylnd added the release_note:skip Skip the PR/issue when compiling release notes label Oct 13, 2023
@rylnd
Copy link
Contributor Author

rylnd commented Oct 13, 2023

Flaky test run: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3503

@rylnd rylnd requested a review from nkhristinin October 26, 2023 18:41
nkhristinin
nkhristinin approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@nkhristinin nkhristinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvements!

@nkhristinin
Copy link
Contributor

@rylnd we also have conflicts, because some test was skipped, I suggest merging this PR, and in @WafaaNasr PR we can try figure out why it's flakky

@rylnd
Merge branch 'main' into ea_integration_test_cleanup
c2af4dd 
 Conflicts:
	x-pack/test/detection_engine_api_integration/security_and_spaces/group10/risk_engine/init_and_status_apis.ts
@rylnd rylnd enabled auto-merge (squash) November 8, 2023 17:27
@rylnd rylnd merged commit ed9956d into elastic:main Nov 8, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #60 / EPM Endpoints Install endpoint package install should have installed the [endpoint.metadata_current-default] transform
  • [job] [logs] Investigations - Security Solution Cypress Tests #2 / Ransomware Detection Alerts Ransomware in Timelines Renders ransomware entries in timelines table Renders ransomware entries in timelines table

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rylnd

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 8, 2023
@rylnd rylnd deleted the ea_integration_test_cleanup branch November 8, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkhristinin nkhristinin nkhristinin approved these changes

Assignees

@rylnd rylnd

Labels
backport:skip This commit does not require backporting chore Feature:Entity Analytics Security Solution Entity Analytics features release_note:skip Skip the PR/issue when compiling release notes technical debt Improvement of the software architecture and operational architecture Theme: entity_analytics v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rylnd @nkhristinin @kibana-ci @kibanamachine