Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EDR Workflows] Policy Details Settings - change view mode UX #168850

Closed
wants to merge 4 commits into from
Closed

[EDR Workflows] Policy Details Settings - change view mode UX #168850

wants to merge 4 commits into from

Conversation

szwarckonrad
Copy link
Contributor

@szwarckonrad szwarckonrad commented Oct 13, 2023 •
edited
Loading

#168428

This pull request modifies the way a user views policy details settings when they lack write permissions. The changes have been implemented on the Policy Settings and Protection Updates tabs, focusing on disabling input fields instead of rendering text. You can find additional information in the linked ticket above.

How it looks now:

Screenshot 2023-10-13 at 15 51 55
Screenshot 2023-10-13 at 15 51 50

How will it look with this PR:

Screenshot 2023-10-13 at 15 39 09
Screenshot 2023-10-13 at 15 38 51

Screen.Recording.2023-10-13.at.15.44.16.mov

@szwarckonrad szwarckonrad added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.12.0 labels Oct 13, 2023
@szwarckonrad szwarckonrad self-assigned this Oct 13, 2023
@szwarckonrad szwarckonrad mentioned this pull request Oct 13, 2023
Closed
@szwarckonrad
Merge branch 'main' into fix-policy-detail-view-mode
676f1ac 
# Conflicts:
#	x-pack/plugins/security_solution/public/management/pages/policy/view/protection_updates/protection_updates_layout.tsx
@szwarckonrad szwarckonrad marked this pull request as ready for review October 16, 2023 07:59
@szwarckonrad szwarckonrad requested a review from a team as a code owner October 16, 2023 07:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@szwarckonrad szwarckonrad requested review from paul-tavares and removed request for joeypoon October 16, 2023 07:59
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.0MB 13.0MB -2.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @szwarckonrad

@paul-tavares
Copy link
Contributor

@szwarckonrad ,
This PR essentially reverts the changes that were done with #161511 - those changes specifically displayed a page as text when the user does not have Authz to the page, which is a better UX than having disabled form elements. I had also met and discussed those changes with @caitlinbetz when they were introduced and we all agreed it was a better user experience.

Why do you need to have these form display with disabled form elements when a user does not have Authz. Edit/Delete?

@szwarckonrad
Copy link
Contributor Author

Closed in favor of #169920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski patrykkopycinski was automatically assigned from elastic/security-defend-workflows

@paul-tavares paul-tavares Awaiting requested review from paul-tavares

Assignees

@szwarckonrad szwarckonrad

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szwarckonrad @elasticmachine @kibana-ci @paul-tavares