-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Add support for additional types for dynamic mappings #168842
Merged
jsoriano
merged 11 commits into
elastic:main
from
jsoriano:scaled-float-dynamic-mapping
Oct 17, 2023
Merged
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0855613
[Fleet] Add support for additional types for dynamic mappings
jsoriano 0827919
Fix linting
jsoriano 2b454ab
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 5517847
Merge remote-tracking branch 'origin/main' into scaled-float-dynamic-…
jsoriano 5beeadf
Linting and support for flattened
jsoriano 49638d7
Merge remote-tracking branch 'jsoriano/scaled-float-dynamic-mapping' …
jsoriano 77c4c01
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine 7a54b24
More linting
jsoriano 061953c
Merge remote-tracking branch 'origin/main' into scaled-float-dynamic-…
jsoriano 445018c
Add unsigned long
jsoriano 2d1dfd4
Linting
jsoriano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -216,10 +216,8 @@ function _generateMappings( | |
case 'double': | ||
case 'long': | ||
case 'boolean': | ||
dynProperties = { | ||
type: field.object_type, | ||
time_series_metric: field.metric_type, | ||
}; | ||
dynProperties.type = field.object_type; | ||
dynProperties.time_series_metric = field.metric_type; | ||
matchingType = field.object_type_mapping_type ?? field.object_type; | ||
default: | ||
break; | ||
|
@@ -258,27 +256,64 @@ function _generateMappings( | |
dynProperties = histogram(field); | ||
matchingType = field.object_type_mapping_type ?? '*'; | ||
break; | ||
case 'ip': | ||
case 'keyword': | ||
case 'match_only_text': | ||
case 'text': | ||
case 'wildcard': | ||
dynProperties.type = field.object_type; | ||
matchingType = field.object_type_mapping_type ?? 'string'; | ||
break; | ||
case 'keyword': | ||
case 'scaled_float': | ||
dynProperties = scaledFloat(field); | ||
matchingType = field.object_type_mapping_type ?? '*'; | ||
break; | ||
case 'aggregate_metric_double': | ||
dynProperties.type = field.object_type; | ||
matchingType = field.object_type_mapping_type ?? 'string'; | ||
dynProperties.metrics = field.metrics; | ||
dynProperties.default_metric = field.default_metric; | ||
matchingType = field.object_type_mapping_type ?? '*'; | ||
break; | ||
case 'byte': | ||
case 'double': | ||
case 'float': | ||
case 'half_float': | ||
dynProperties.type = field.object_type; | ||
dynProperties.time_series_metric = field.metric_type; | ||
matchingType = field.object_type_mapping_type ?? 'double'; | ||
break; | ||
case 'byte': | ||
case 'long': | ||
case 'short': | ||
dynProperties.type = field.object_type; | ||
dynProperties.time_series_metric = field.metric_type; | ||
matchingType = field.object_type_mapping_type ?? 'long'; | ||
break; | ||
case 'integer': | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should it be added |
||
// Map integers as long, as in other cases. | ||
dynProperties.type = 'long'; | ||
dynProperties.time_series_metric = field.metric_type; | ||
matchingType = field.object_type_mapping_type ?? 'long'; | ||
break; | ||
case 'boolean': | ||
dynProperties = { | ||
type: field.object_type, | ||
time_series_metric: field.metric_type, | ||
}; | ||
dynProperties.type = field.object_type; | ||
dynProperties.time_series_metric = field.metric_type; | ||
matchingType = field.object_type_mapping_type ?? field.object_type; | ||
default: | ||
break; | ||
case 'group': | ||
const fields = field.fields.map((dynField) => ({ | ||
...dynField, | ||
type: 'object', | ||
object_type: dynField.object_type ?? dynField.type, | ||
})) | ||
_generateMappings(fields, { | ||
...ctx, | ||
groupFieldName: ctx.groupFieldName | ||
? `${ctx.groupFieldName}.${field.name}` | ||
: field.name, | ||
}); | ||
break; | ||
default: | ||
throw new Error(`no dynamic mapping generated for field ${path} of type ${field.object_type}`); | ||
} | ||
|
||
if (dynProperties && matchingType) { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some types that are not specified in the
object_type
field definition in package-spec: ip, wildcard, group or match_only_textShould these be added too here?