Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unskips application leave confirm & application deep links tests #168741

Merged
merged 26 commits into from
Oct 19, 2023
Merged

unskips application leave confirm & application deep links tests #168741

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
0feeb53
unskips tests failing in CI
TinaHeiligers Oct 12, 2023
a49010c
Merge branch 'main' into skipped-tests-app-leave-deep-links
kibanamachine Oct 12, 2023
5fc9a09
Merge branch 'main' into skipped-tests-app-leave-deep-links
kibanamachine Oct 13, 2023
c61ef3d
Merge branch 'main' into skipped-tests-app-leave-deep-links
kibanamachine Oct 14, 2023
4713ed5
Use consistent nav link title, name
TinaHeiligers Oct 15, 2023
15096a6
adds debug log for current URL
TinaHeiligers Oct 15, 2023
4c080ea
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine Oct 16, 2023
59995c8
Merge branch 'main' into skipped-tests-app-leave-deep-links
kibanamachine Oct 16, 2023
cc6f57f
Improves tests
TinaHeiligers Oct 16, 2023
6f2f392
Merge branch 'main' into skipped-tests-app-leave-deep-links
kibanamachine Oct 16, 2023
41e0dcb
Merge branch 'main' into skipped-tests-app-leave-deep-links
TinaHeiligers Oct 16, 2023
06e050d
Merge branch 'main' into skipped-tests-app-leave-deep-links
kibanamachine Oct 16, 2023
eb25bbc
Ensure app navigates to app home url
TinaHeiligers Oct 17, 2023
d0ae7d2
Swap test order to force browser response
TinaHeiligers Oct 17, 2023
16bb946
Merge branch 'main' into skipped-tests-app-leave-deep-links
kibanamachine Oct 17, 2023
cd2f7a5
updates test plugin and page objects methods to accomodate latest beh…
TinaHeiligers Oct 17, 2023
77ceb45
Merge branch 'skipped-tests-app-leave-deep-links' of github.com:TinaH…
TinaHeiligers Oct 17, 2023
ca94111
Merge branch 'main' into skipped-tests-app-leave-deep-links
kibanamachine Oct 17, 2023
18abd6b
check exists for the correct modal test subject
TinaHeiligers Oct 17, 2023
fac7c79
Merge branch 'skipped-tests-app-leave-deep-links' of github.com:TinaH…
TinaHeiligers Oct 17, 2023
1e08998
Refactors tests, helpers and plugin to take delayed rendering into ac…
TinaHeiligers Oct 18, 2023
473c1fd
Increase waitFor timeout more
TinaHeiligers Oct 18, 2023
d725990
Change data test subject
TinaHeiligers Oct 18, 2023
81579c4
increase timeout even more
TinaHeiligers Oct 18, 2023
8d1c8a2
Move nav click event into retry
TinaHeiligers Oct 18, 2023
0f5277f
Merge branch 'main' into skipped-tests-app-leave-deep-links
kibanamachine Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/plugin_functional/test_suites/core_plugins/application_deep_links.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ export default function ({ getService, getPageObjects }: PluginFunctionalProvide
});
};

// Failing: See https://github.com/elastic/kibana/issues/166893
describe.skip('application deep links navigation', function describeDeepLinksTests() {
describe('application deep links navigation', function describeDeepLinksTests() {
Copy link
Contributor Author

@TinaHeiligers TinaHeiligers Oct 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/appex-sharedux I could use a hand in figuring out why tests using appMenu.clickLink fail in CI and pass locally. The most recent changes to relevant components seems to be with CollapsibleNav but that was 4 months ago.

The appLeave test failed because the modal wasn't visible.

before(async () => {
await esArchiver.emptyKibanaIndex();
await PageObjects.common.navigateToApp('dl');
Expand Down
4 changes: 1 addition & 3 deletions test/plugin_functional/test_suites/core_plugins/application_leave_confirm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@ export default function ({ getService, getPageObjects }: PluginFunctionalProvide
const appsMenu = getService('appsMenu');
const testSubjects = getService('testSubjects');

// Failing: See https://github.com/elastic/kibana/issues/75963
// Failing: See https://github.com/elastic/kibana/issues/166838
describe.skip('application using leave confirmation', () => {
describe('application using leave confirmation', () => {
Copy link
Contributor Author

@TinaHeiligers TinaHeiligers Oct 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test suite needed a complete overhaul to account for increased delays that various background tasks perform (ebt data collection, fleet setup etc).

describe('when navigating to another app', () => {
it('prevents navigation if user click cancel on the confirmation dialog', async () => {
await PageObjects.common.navigateToApp('appleave1');
Expand Down