-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAM] add observability feature for server less #168636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XavierM, I wanted to check the Alert doc via DevTool, but I couldn't find the index. We are hiding these indices on serverless?
I will just use |
…ility as a consumer
@mgiota, that's true, It's disabled by default for serverless. But as this PR is serverless-related only. In order to test it, you need to switch the feature flag on as I did. |
also fixes #167053 |
This comment was marked as resolved.
This comment was marked as resolved.
Pinging @elastic/response-ops (Team:ResponseOps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ResponseOps changes look good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the active alerts hooks 👍🏻 LGTM
…ana into add-feature-o11y-server-less
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
@XavierM Kevin's valid comment put me into thoughts regarding the feature_ids we pass to other observability rule types. These will need to be changed too, otherwise generated alerts will probably not be displayed in the respective apps on serverless, if my understanding is correct,right? One example is here apm latency alerts history chart. I can gather the places that need to be changed and fix them. Can you please verify that I need to make changes to rest observability places that specify feature ids? Maybe it is not needed, I need to revisit again how the alert authorization works. I need your input for verification. |
## Summary FIX => elastic#168034 ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: mgiota <[email protected]> Co-authored-by: kibanamachine <[email protected]>
Summary
FIX => #168034
Checklist