[Security Solution][Detection Engine] updates ES|QL info popover #168611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaliidm
changed the title
vitaliidm
added
Team:Detections and Resp
…liidm/kibana into detection-engine/esql-popover
…liidm/kibana into detection-engine/esql-popover
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
nastasha-solomon
approved these changes
Oct 16, 2023
.../security_solution/public/detection_engine/rule_creation/components/esql_info_icon/index.tsx
Outdated
Show resolved
Hide resolved
…creation/components/esql_info_icon/index.tsx Co-authored-by: Nastasha Solomon <[email protected]>
…liidm/kibana into detection-engine/esql-popover
banderror
approved these changes
Oct 16, 2023
💔 Build FailedFailed CI StepsMetrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @vitaliidm |
4 tasks
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2023
…stic#168611) ## Summary - addresses elastic/ux-writing#41 - content of info tooltip is moved to doc page. Instead only link to that page is displayed ### Before <img width="1459" alt="Screenshot 2023-10-13 at 15 56 20" src="https://github.com/elastic/kibana/assets/92328789/9a00ea01-19c1-4639-ad7b-9ae92829f075"> ### After <img width="1298" alt="Screenshot 2023-10-13 at 15 53 07" src="https://github.com/elastic/kibana/assets/92328789/84811780-5d42-4ed3-b0d6-200467443e2f"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Nastasha Solomon <[email protected]> (cherry picked from commit 761fa51)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Oct 18, 2023
…stic#168611) ## Summary - addresses elastic/ux-writing#41 - content of info tooltip is moved to doc page. Instead only link to that page is displayed ### Before <img width="1459" alt="Screenshot 2023-10-13 at 15 56 20" src="https://github.com/elastic/kibana/assets/92328789/9a00ea01-19c1-4639-ad7b-9ae92829f075"> ### After <img width="1298" alt="Screenshot 2023-10-13 at 15 53 07" src="https://github.com/elastic/kibana/assets/92328789/84811780-5d42-4ed3-b0d6-200467443e2f"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Nastasha Solomon <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 18, 2023
…er (#168611) (#169203) # Backport This will backport the following commits from `main` to `8.11`: - [[Security Solution][Detection Engine] updates ES|QL info popover (#168611)](#168611) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Vitalii Dmyterko","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-18T08:16:16Z","message":"[Security Solution][Detection Engine] updates ES|QL info popover (#168611)\n\n## Summary\r\n\r\n- addresses https://github.com/elastic/ux-writing/issues/41\r\n- content of info tooltip is moved to doc page. Instead only link to\r\nthat page is displayed\r\n\r\n\r\n### Before\r\n\r\n<img width=\"1459\" alt=\"Screenshot 2023-10-13 at 15 56 20\"\r\nsrc=\"https://github.com/elastic/kibana/assets/92328789/9a00ea01-19c1-4639-ad7b-9ae92829f075\">\r\n\r\n\r\n### After\r\n\r\n<img width=\"1298\" alt=\"Screenshot 2023-10-13 at 15 53 07\"\r\nsrc=\"https://github.com/elastic/kibana/assets/92328789/84811780-5d42-4ed3-b0d6-200467443e2f\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Nastasha Solomon <[email protected]>","sha":"761fa5173c22dcca20ee4a6e499d85237f8773bc","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections and Resp","Team: SecuritySolution","backport:prev-minor","Team:Detection Engine","v8.11.0","v8.12.0"],"number":168611,"url":"https://github.com/elastic/kibana/pull/168611","mergeCommit":{"message":"[Security Solution][Detection Engine] updates ES|QL info popover (#168611)\n\n## Summary\r\n\r\n- addresses https://github.com/elastic/ux-writing/issues/41\r\n- content of info tooltip is moved to doc page. Instead only link to\r\nthat page is displayed\r\n\r\n\r\n### Before\r\n\r\n<img width=\"1459\" alt=\"Screenshot 2023-10-13 at 15 56 20\"\r\nsrc=\"https://github.com/elastic/kibana/assets/92328789/9a00ea01-19c1-4639-ad7b-9ae92829f075\">\r\n\r\n\r\n### After\r\n\r\n<img width=\"1298\" alt=\"Screenshot 2023-10-13 at 15 53 07\"\r\nsrc=\"https://github.com/elastic/kibana/assets/92328789/84811780-5d42-4ed3-b0d6-200467443e2f\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Nastasha Solomon <[email protected]>","sha":"761fa5173c22dcca20ee4a6e499d85237f8773bc"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168611","number":168611,"mergeCommit":{"message":"[Security Solution][Detection Engine] updates ES|QL info popover (#168611)\n\n## Summary\r\n\r\n- addresses https://github.com/elastic/ux-writing/issues/41\r\n- content of info tooltip is moved to doc page. Instead only link to\r\nthat page is displayed\r\n\r\n\r\n### Before\r\n\r\n<img width=\"1459\" alt=\"Screenshot 2023-10-13 at 15 56 20\"\r\nsrc=\"https://github.com/elastic/kibana/assets/92328789/9a00ea01-19c1-4639-ad7b-9ae92829f075\">\r\n\r\n\r\n### After\r\n\r\n<img width=\"1298\" alt=\"Screenshot 2023-10-13 at 15 53 07\"\r\nsrc=\"https://github.com/elastic/kibana/assets/92328789/84811780-5d42-4ed3-b0d6-200467443e2f\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Nastasha Solomon <[email protected]>","sha":"761fa5173c22dcca20ee4a6e499d85237f8773bc"}}]}] BACKPORT--> Co-authored-by: Vitalii Dmyterko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before
After
Checklist
Delete any items that are not applicable to this PR.