Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ON WEEK] Add alerting_test_data package and a script to create rules for manual testing #168493

Merged

Conversation

maryam-saeidi
Copy link
Member

@maryam-saeidi maryam-saeidi commented Oct 10, 2023

Closes https://github.com/elastic/actionable-observability/issues/140

Summary

Add alerting_test_data package to create custom threshold and APM rules for manual testing.

More information about the usage: https://github.com/elastic/actionable-observability/pull/156

@maryam-saeidi maryam-saeidi self-assigned this Oct 10, 2023
@maryam-saeidi maryam-saeidi added the release_note:skip Skip the PR/issue when compiling release notes label Oct 10, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@maryam-saeidi maryam-saeidi changed the title Add alerting_test_data package to generate come custom threshold rules Add alerting_test_data package to generate some custom threshold rules Oct 10, 2023
@maryam-saeidi maryam-saeidi marked this pull request as ready for review October 13, 2023 10:40
@maryam-saeidi maryam-saeidi changed the title Add alerting_test_data package to generate some custom threshold rules Add alerting_test_data package and a script to generate some custom threshold rules Oct 13, 2023
@maryam-saeidi maryam-saeidi changed the title Add alerting_test_data package and a script to generate some custom threshold rules Add alerting_test_data package and a script to create rules for manual testing Oct 13, 2023
@maryam-saeidi maryam-saeidi requested a review from a team October 13, 2023 10:46
@mgiota mgiota self-requested a review October 13, 2023 11:06
@mgiota mgiota self-requested a review October 16, 2023 12:14
Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maryam-saeidi Great work! So handy having your script generate rules and alerts!

Here's what I got when I ran node ./scripts/create_observability_rules.js

Screenshot 2023-10-16 at 14 10 18

When I changed the KIBANA_DEFAULT_URL from 'http://127.0.0.1:5601/kibana' to 'http://127.0.0.1:5601', I was then able to run the create_observability_rules.js script and get automatically generated rules and alerts.

Screenshot 2023-10-16 at 14 10 50 Screenshot 2023-10-16 at 14 11 07

So I am wondering if the KIBANA_DEFAULT_URL is correct. I have the impression that most people run kibana under 'http://127.0.0.1:5601', no?

@mgiota mgiota self-requested a review October 17, 2023 07:42
@maryam-saeidi
Copy link
Member Author

@mgiota I addressed your comments, would you please check it again? :)

Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/observability-alerting-test-data - 99 +99

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
@kbn/observability-alerting-test-data - 1 +1

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
observability 14 16 +2
Unknown metric groups

API count

id before after diff
@kbn/observability-alerting-test-data - 99 +99

ESLint disabled in files

id before after diff
@kbn/observability-alerting-test-data - 1 +1

ESLint disabled line counts

id before after diff
@kbn/observability-alerting-test-data - 1 +1

Total ESLint disabled count

id before after diff
@kbn/observability-alerting-test-data - 2 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@maryam-saeidi maryam-saeidi merged commit 6d88fb5 into elastic:main Oct 18, 2023
@maryam-saeidi maryam-saeidi deleted the 140-on-week-auto-rule-creation branch October 18, 2023 10:00
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Oct 18, 2023
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Oct 18, 2023
…l testing (elastic#168493)

Closes elastic/actionable-observability#140

## Summary

Add alerting_test_data package to create custom threshold and APM rules
for manual testing.

More information about the usage:
elastic/actionable-observability#156

---------

Co-authored-by: almudenasanz <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
@maryam-saeidi maryam-saeidi changed the title Add alerting_test_data package and a script to create rules for manual testing [ON WEEK] Add alerting_test_data package and a script to create rules for manual testing Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants