[Synthetics] Fix doc links for alerts and documentation #168486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awahab07
added
bug
|
Pinging @elastic/uptime (Team:uptime) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
awahab07
force-pushed
the
167688-fix-synthetics-alert-rule-docs-links
branch
from
598ec0d to
b47192d
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
shahzad31
approved these changes
Oct 11, 2023
colleenmcginnis
approved these changes
Oct 11, 2023
| }, | ||
| { | ||
| linkType: 'discuss', | ||
| href: 'https://discuss.elastic.co/c/uptime', // TODO: Include synthetics link | ||
| href: 'https://discuss.elastic.co/c/uptime', // Redirects to https://discuss.elastic.co/c/observability/synthetics/75 |
There was a problem hiding this comment.
Just curious.. is there any reason not to point to the synthetics link instead of triggering a redirect?
There was a problem hiding this comment.
I am not confident how static is https://discuss.elastic.co/c/observability/synthetics/75 (seeing 75 in it), so I left it as is. However, I am open to suggestions.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 11, 2023
Fixes elastic#167688 ## Summary Updates the links to Synthetics from Uptime on the following: 1. "learn more" link on Monitor Status alert flyout 2. "learn more" link on TLS alert flyout 3. Synthetics app "Documentation" link (under _help_ top header button) (cherry picked from commit 598adef)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 12, 2023
…) (#168637) # Backport This will backport the following commits from `main` to `8.11`: - [[Synthetics] Fix doc links for alerts and documentation (#168486)](#168486) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Abdul Wahab Zahid","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-11T15:56:10Z","message":"[Synthetics] Fix doc links for alerts and documentation (#168486)\n\nFixes #167688 \r\n\r\n## Summary\r\n\r\nUpdates the links to Synthetics from Uptime on the following:\r\n1. \"learn more\" link on Monitor Status alert flyout\r\n2. \"learn more\" link on TLS alert flyout\r\n3. Synthetics app \"Documentation\" link (under _help_ top header button)","sha":"598adef415899656cdace9b45729f84c125a6a60","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.11.0","v8.12.0"],"number":168486,"url":"https://github.com/elastic/kibana/pull/168486","mergeCommit":{"message":"[Synthetics] Fix doc links for alerts and documentation (#168486)\n\nFixes #167688 \r\n\r\n## Summary\r\n\r\nUpdates the links to Synthetics from Uptime on the following:\r\n1. \"learn more\" link on Monitor Status alert flyout\r\n2. \"learn more\" link on TLS alert flyout\r\n3. Synthetics app \"Documentation\" link (under _help_ top header button)","sha":"598adef415899656cdace9b45729f84c125a6a60"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168486","number":168486,"mergeCommit":{"message":"[Synthetics] Fix doc links for alerts and documentation (#168486)\n\nFixes #167688 \r\n\r\n## Summary\r\n\r\nUpdates the links to Synthetics from Uptime on the following:\r\n1. \"learn more\" link on Monitor Status alert flyout\r\n2. \"learn more\" link on TLS alert flyout\r\n3. Synthetics app \"Documentation\" link (under _help_ top header button)","sha":"598adef415899656cdace9b45729f84c125a6a60"}}]}] BACKPORT--> Co-authored-by: Abdul Wahab Zahid <[email protected]> Co-authored-by: Shahzad <[email protected]>
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
Fixes elastic#167688 ## Summary Updates the links to Synthetics from Uptime on the following: 1. "learn more" link on Monitor Status alert flyout 2. "learn more" link on TLS alert flyout 3. Synthetics app "Documentation" link (under _help_ top header button)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167688
Summary
Updates the links to Synthetics from Uptime on the following: