Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDR Workflows][E2E] Increase the timeout of agent check in #168438

Merged
merged 9 commits into from
Oct 11, 2023
Merged

[EDR Workflows][E2E] Increase the timeout of agent check in #168438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2c0375e
increase the timeout
szwarckonrad Oct 10, 2023
b54509c
Merge branch 'main' into fix-e2e-agent-check-in-timeout
szwarckonrad Oct 10, 2023
33099cc
Merge branch 'main' into fix-e2e-agent-check-in-timeout
szwarckonrad Oct 10, 2023
ddca65a
timeout
szwarckonrad Oct 10, 2023
1904836
Merge remote-tracking branch 'origin/fix-e2e-agent-check-in-timeout' …
szwarckonrad Oct 10, 2023
095ac7b
Merge branch 'main' into fix-e2e-agent-check-in-timeout
szwarckonrad Oct 10, 2023
75e5b32
Merge branch 'main' into fix-e2e-agent-check-in-timeout
szwarckonrad Oct 10, 2023
f61385c
Merge branch 'main' into fix-e2e-agent-check-in-timeout
szwarckonrad Oct 10, 2023
dc15238
Merge branch 'main' into fix-e2e-agent-check-in-timeout
szwarckonrad Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/public/management/cypress/tasks/create_endpoint_host.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ export const createEndpointHost = (
{
agentPolicyId,
},
{ timeout: timeout ?? 600000 }
{ timeout: timeout ?? 900000 } // 15 minutes, since setup can take 10 minutes and more. Task will time out if is not resolved within this time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any other way to speed up this instead of increasing the timeout?

Copy link
Contributor Author

@szwarckonrad szwarckonrad Oct 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. If cypress task that set ups and enrols agent doesn't resolve within this timeout the task and test fails. We have noticed, that at some occurrences this 10 minutes is not enough to download, install, enroll and wait for agent to show up in fleet and test fails making it flaky not because of the test itself but this setup task. We could investigate a way to make this task faster or break it into several tasks but that should be a spike, this PR aims at stabilizing our test runs now.

);
};
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/scripts/endpoint/common/endpoint_host_services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ const enrollHostWithFleet = async ({
]);
}
log.info(`Waiting for Agent to check-in with Fleet`);
const agent = await waitForHostToEnroll(kbnClient, vmName, 120000);
const agent = await waitForHostToEnroll(kbnClient, vmName, 240000);

return {
agentId: agent.id,
Expand Down
Loading