[Security Solution] expandable flyout - same source alert chage #168395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
Team:Threat Hunting:Investigations
PhilippeOberti
force-pushed
the
expandable-flyout-same-source-event
branch
3 times, most recently
from
5c65291 to
2a0ffe7
Compare
…lert.original_event.id for same source even related alerts
PhilippeOberti
force-pushed
the
expandable-flyout-same-source-event
branch
from
2a0ffe7 to
887f9d1
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
PhilippeOberti
added
the
release_note:skip
christineweng
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
thanks for this clean up!
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
PhilippeOberti
added
v8.11.1
backport:prev-minor
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2023
…tic#168395) (cherry picked from commit deabe63)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 18, 2023
#168395) (#169267) # Backport This will backport the following commits from `main` to `8.11`: - [[Security Solution] expandable flyout - same source alert chage (#168395)](#168395) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-10T20:53:16Z","message":"[Security Solution] expandable flyout - same source alert chage (#168395)","sha":"deabe637ef3e3634b2ea5cac3f4da81da42a65e1","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","backport:prev-minor","v8.12.0","v8.11.1"],"number":168395,"url":"https://github.com/elastic/kibana/pull/168395","mergeCommit":{"message":"[Security Solution] expandable flyout - same source alert chage (#168395)","sha":"deabe637ef3e3634b2ea5cac3f4da81da42a65e1"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168395","number":168395,"mergeCommit":{"message":"[Security Solution] expandable flyout - same source alert chage (#168395)","sha":"deabe637ef3e3634b2ea5cac3f4da81da42a65e1"}},{"branch":"8.11","label":"v8.11.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes a small change to the way we retrieve the same source related alerts in the Security Solution expandable flyout alert details. Instead of using the value from the
kibana.alert.ancestors.idfield, we're now using the value fromkibana.alert.original_event.idfield.No UI has been changed.
https://github.com/elastic/security-team/issues/7778