Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data_visualizer] Migrate deprecated EuiPage* component #168298

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Oct 6, 2023

Summary

EUI will shortly be removing several deprecated EuiPage* components, and we're updating a few remaining Kibana usages of these deprecated components ahead of time.

⚠️ PLEASE NOTE: We have not QA'd these changes to ensure that the UI is 1:1 from before. We do not have the domain knowledge or time to spin up local instances of all plugins with deprecations, and ask that the CODEOWNING team pull down this branch and QA the affected page(s) locally to ensure the UI looks like the same as production. ⚠️

See #161872 for other similar tasks with more information about this effort.

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.12.0 labels Oct 6, 2023
@cee-chen cee-chen changed the title [data_virtualizer] Migrate deprecated EuiPage* component [data_visualizer] Migrate deprecated EuiPage* component Oct 6, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #6 / Alert details expandable flyout right panel should mark as closed should mark as closed

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 613.3KB 613.3KB -18.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen marked this pull request as ready for review October 6, 2023 23:34
@cee-chen cee-chen requested a review from a team as a code owner October 6, 2023 23:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@qn895 qn895 self-requested a review October 6, 2023 23:39
@qn895
Copy link
Member

qn895 commented Oct 9, 2023

Tested and LGTM 🎉

@cee-chen
Copy link
Member Author

cee-chen commented Oct 9, 2023

Thanks @qn895!! You rock as always :)

@cee-chen cee-chen merged commit e672224 into elastic:main Oct 9, 2023
39 checks passed
@cee-chen cee-chen deleted the eui-page-deprecated/ml-ui branch October 9, 2023 15:57
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 9, 2023
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
…8298)

## Summary

EUI will shortly be removing several deprecated `EuiPage*` components,
and we're updating a few remaining Kibana usages of these deprecated
components ahead of time.

⚠️ PLEASE NOTE: We have **not** QA'd these changes to ensure that the UI
is 1:1 from before. We do not have the domain knowledge or time to spin
up local instances of all plugins with deprecations, and ask that the
CODEOWNING team pull down this branch and QA the affected page(s)
locally to ensure the UI looks like the same as production. ⚠️

See elastic#161872 for other similar
tasks with more information about this effort.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants