-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data views] Allow data views created on hidden and system indices #168174
[data views] Allow data views created on hidden and system indices #168174
Conversation
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM and it worked well when testing, although I encountered something strange when running the functional test. For some reason the test didn't seem to check the "Allow hidden" toggle, but it was still able to find the index and save the data view. I couldn't reproduce while testing though, hidden indices were only showing when the toggle was enabled:
func_test_2.mp4
The test also still succeeded for me when I changed the allowHidden
param of PageObjects.settings.createIndexPattern
to false
, which didn't seem like it should work either.
I also noticed while I was testing that when editing, the advanced settings menu was collapsed, the "Allow hidden" toggle was off, and the index wasn't found in the sources, but I think maybe that's a known issue and unrelated to this PR?
Approving now since the approach looks good and it worked locally, but might be worth following up on the functional test thing to see if you can reproduce.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
limits.yml
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: cc @mattkime |
@mattkime Would it be possible to backport this to 8.11.0? |
@sqren Unfortunately due to changes in data view persistence and field caps calls, I think it would be too risky |
…lastic#168174) ## Summary Previously, the 'Allow hidden and system indices' advanced option when creating a data view was only a UI convenience. It allowed you to see which hidden and system indices you were matching but they would be would be selected just the same once the data view was loaded. At some point something changed and now there are system and hidden indices that require `expandWildcards: hidden` to be passed to field caps in order to see anything. `allowHidden: boolean` is added to the DataView and DataViewSpec and passed through when field caps requests are made. This is primarily a tool for troubleshooting. For instance, instead of hitting a full data stream across a number of data tiers you can select a specific index to compare its performance. Closes: elastic#164652
…dices" (elastic#168855) Reverts elastic#168174 Reverting the previous PR - tests passed and the PR appeared to work because ES is doesn't always enforce 'allowHidden' on hidden indices.
Summary
Previously, the 'Allow hidden and system indices' advanced option when creating a data view was only a UI convenience. It allowed you to see which hidden and system indices you were matching but they would be would be selected just the same once the data view was loaded. At some point something changed and now there are system and hidden indices that require
expandWildcards: hidden
to be passed to field caps in order to see anything.allowHidden: boolean
is added to the DataView and DataViewSpec and passed through when field caps requests are made.This is primarily a tool for troubleshooting. For instance, instead of hitting a full data stream across a number of data tiers you can select a specific index to compare its performance.
Closes: #164652