fix(slo): use insert_zeros gap policy for historical summary calculation #168044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelemme
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
maryam-saeidi
approved these changes
Oct 4, 2023
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @kdelemme |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kdelemme
added a commit
to kdelemme/kibana
that referenced
this pull request
Oct 5, 2023
…ion (elastic#168044) (cherry picked from commit cee55e3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 5, 2023
…ion (elastic#168044) (cherry picked from commit cee55e3)
kibanamachine
added a commit
that referenced
this pull request
Oct 5, 2023
…alculation (#168044) (#168135) # Backport This will backport the following commits from `main` to `8.11`: - [fix(slo): use insert_zeros gap policy for historical summary calculation (#168044)](#168044) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-05T17:01:26Z","message":"fix(slo): use insert_zeros gap policy for historical summary calculation (#168044)","sha":"cee55e3b50fffa9e1237c389d030a5c25bdb3f6a","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: Actionable Observability","backport:prev-minor","v8.12.0"],"number":168044,"url":"https://github.com/elastic/kibana/pull/168044","mergeCommit":{"message":"fix(slo): use insert_zeros gap policy for historical summary calculation (#168044)","sha":"cee55e3b50fffa9e1237c389d030a5c25bdb3f6a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168044","number":168044,"mergeCommit":{"message":"fix(slo): use insert_zeros gap policy for historical summary calculation (#168044)","sha":"cee55e3b50fffa9e1237c389d030a5c25bdb3f6a"}}]}] BACKPORT--> Co-authored-by: Kevin Delemme <[email protected]>
kdelemme
added a commit
to kdelemme/kibana
that referenced
this pull request
Oct 6, 2023
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #168042
Summary
When the rollup data is too intermittent, some of the generated histogram buckets can be empty, and when calculating the moving sum, these empty buckets were skipped.
Using
gap_policy: "insert_zeros"fixes that issue.