Fixes rendering service config keys test #167937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeramysoucy
changed the title
jeramysoucy
added
the
Team:Security
jeramysoucy
added
v8.11.0
release_note:skip
jeramysoucy
added
backport:prev-minor
jeramysoucy
added
backport:all-open
|
Pinging @elastic/kibana-security (Team:Security) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 5, 2023
Closes elastic#167142 Closes elastic#157126 ## Summary Fortifies the rendering service tests by introducing a retry loop to get injected metadata after navigation. The `kbn-injected-metadata` tag that we're relying on in this test gets removed some time after navigation (e.g. to `.../render/core`). It appears that occasionally this test fails to read the tag before it is removed. Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3363 --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 335a751)
This was referenced Oct 5, 2023
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 5, 2023
Closes elastic#167142 Closes elastic#157126 ## Summary Fortifies the rendering service tests by introducing a retry loop to get injected metadata after navigation. The `kbn-injected-metadata` tag that we're relying on in this test gets removed some time after navigation (e.g. to `.../render/core`). It appears that occasionally this test fails to read the tag before it is removed. Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3363 --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 335a751)
kibanamachine
added a commit
that referenced
this pull request
Oct 5, 2023
# Backport This will backport the following commits from `main` to `8.11`: - [Fixes rendering service config keys test (#167937)](#167937) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jeramy Soucy","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-05T17:59:19Z","message":"Fixes rendering service config keys test (#167937)\n\nCloses #167142\r\nCloses #157126\r\n\r\n## Summary\r\n\r\nFortifies the rendering service tests by introducing a retry loop to get\r\ninjected metadata after navigation. The `kbn-injected-metadata` tag that\r\nwe're relying on in this test gets removed some time after navigation\r\n(e.g. to `.../render/core`). It appears that occasionally this test\r\nfails to read the tag before it is removed.\r\n\r\nFlaky test runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3363\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"335a751c00b2743d4e4adf53425f1fb45a54e883","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","backport:all-open","v8.11.0","v8.12.0"],"number":167937,"url":"https://github.com/elastic/kibana/pull/167937","mergeCommit":{"message":"Fixes rendering service config keys test (#167937)\n\nCloses #167142\r\nCloses #157126\r\n\r\n## Summary\r\n\r\nFortifies the rendering service tests by introducing a retry loop to get\r\ninjected metadata after navigation. The `kbn-injected-metadata` tag that\r\nwe're relying on in this test gets removed some time after navigation\r\n(e.g. to `.../render/core`). It appears that occasionally this test\r\nfails to read the tag before it is removed.\r\n\r\nFlaky test runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3363\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"335a751c00b2743d4e4adf53425f1fb45a54e883"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/167937","number":167937,"mergeCommit":{"message":"Fixes rendering service config keys test (#167937)\n\nCloses #167142\r\nCloses #157126\r\n\r\n## Summary\r\n\r\nFortifies the rendering service tests by introducing a retry loop to get\r\ninjected metadata after navigation. The `kbn-injected-metadata` tag that\r\nwe're relying on in this test gets removed some time after navigation\r\n(e.g. to `.../render/core`). It appears that occasionally this test\r\nfails to read the tag before it is removed.\r\n\r\nFlaky test runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3363\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"335a751c00b2743d4e4adf53425f1fb45a54e883"}}]}] BACKPORT--> Co-authored-by: Jeramy Soucy <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 6, 2023
# Backport This will backport the following commits from `main` to `7.17`: - [Fixes rendering service config keys test (#167937)](#167937) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jeramy Soucy","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-05T17:59:19Z","message":"Fixes rendering service config keys test (#167937)\n\nCloses #167142\r\nCloses #157126\r\n\r\n## Summary\r\n\r\nFortifies the rendering service tests by introducing a retry loop to get\r\ninjected metadata after navigation. The `kbn-injected-metadata` tag that\r\nwe're relying on in this test gets removed some time after navigation\r\n(e.g. to `.../render/core`). It appears that occasionally this test\r\nfails to read the tag before it is removed.\r\n\r\nFlaky test runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3363\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"335a751c00b2743d4e4adf53425f1fb45a54e883","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","backport:all-open","v8.11.0","v8.12.0"],"number":167937,"url":"https://github.com/elastic/kibana/pull/167937","mergeCommit":{"message":"Fixes rendering service config keys test (#167937)\n\nCloses #167142\r\nCloses #157126\r\n\r\n## Summary\r\n\r\nFortifies the rendering service tests by introducing a retry loop to get\r\ninjected metadata after navigation. The `kbn-injected-metadata` tag that\r\nwe're relying on in this test gets removed some time after navigation\r\n(e.g. to `.../render/core`). It appears that occasionally this test\r\nfails to read the tag before it is removed.\r\n\r\nFlaky test runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3363\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"335a751c00b2743d4e4adf53425f1fb45a54e883"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/167937","number":167937,"mergeCommit":{"message":"Fixes rendering service config keys test (#167937)\n\nCloses #167142\r\nCloses #157126\r\n\r\n## Summary\r\n\r\nFortifies the rendering service tests by introducing a retry loop to get\r\ninjected metadata after navigation. The `kbn-injected-metadata` tag that\r\nwe're relying on in this test gets removed some time after navigation\r\n(e.g. to `.../render/core`). It appears that occasionally this test\r\nfails to read the tag before it is removed.\r\n\r\nFlaky test runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3363\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"335a751c00b2743d4e4adf53425f1fb45a54e883"}}]}] BACKPORT--> Co-authored-by: Jeramy Soucy <[email protected]>
|
Those changes didn't make it on time into the latest BC for 7.17.14. Updating the labels. |
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
Closes elastic#167142 Closes elastic#157126 ## Summary Fortifies the rendering service tests by introducing a retry loop to get injected metadata after navigation. The `kbn-injected-metadata` tag that we're relying on in this test gets removed some time after navigation (e.g. to `.../render/core`). It appears that occasionally this test fails to read the tag before it is removed. Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3363 --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #167142
Closes #157126
Summary
Fortifies the rendering service tests by introducing a retry loop to get injected metadata after navigation. The
kbn-injected-metadatatag that we're relying on in this test gets removed some time after navigation (e.g. to.../render/core). It appears that occasionally this test fails to read the tag before it is removed.Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3363