Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Unskipping x-pack/test/security_solution_cypress/cypress/e2e/explore/dashboards/ working tests on serverless #167916

Merged
merged 14 commits into from
Oct 16, 2023
Merged

[Security Solution] Unskipping x-pack/test/security_solution_cypress/cypress/e2e/explore/dashboards/ working tests on serverless #167916

merged 14 commits into from
Oct 16, 2023
+30 −94

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Oct 3, 2023 •
edited by kibanamachine
Loading

Summary

https://github.com/elastic/security-team/issues/7696

In this PR we are making the following changes regarding the tests living in x-pack/test/security_solution_cypress/cypress/e2e/explore/dashboards/ regarding their execution on the first quality gate for serverless:

  • Unskipped enable_risk_score_redirect.cy.ts
  • In entity_analytics.cy.ts we have deleted the clearSerachBar() methods and clearDates ones. This is because clearSerachBar method has been demonstrated to be extremely problematic in the serverless environment. Also we don't need clean-up methods at the end of the execution of tests because Cypress by default clears the cache between tests, namely cookies, local storage, and session storage.
  • Unskipped entity_analytics_serverless_splash_screen.cy.ts
  • Unskipped upgrade_risk_score.cy.ts
  • For the date_pickers methods I had to force the click to make them work, since I don't know why seems to have a layer on top in serverless.
  • All the changes in the es_archives folder, are around removing the lifecycle entry since we don't support ILM in serverless.

Note that the unskipped tests have been executed several times and are passing consistently :)

Also, the tests that were marked before with .skip remain skipped in both executions.

@MadameSheema MadameSheema changed the title enabling tests [Security Solution] Unskipping x-pack/test/security_solution_cypress/cypress/e2e/explore/dashboards/ working tests on serverless Oct 12, 2023
@MadameSheema MadameSheema self-assigned this Oct 12, 2023
@MadameSheema MadameSheema added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.11.0 v8.12.0 labels Oct 12, 2023
@MadameSheema MadameSheema marked this pull request as ready for review October 12, 2023 14:29
@MadameSheema MadameSheema requested review from a team as code owners October 12, 2023 14:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

charlie-pichette
charlie-pichette approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@charlie-pichette charlie-pichette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I would not expect the lifecycle values in the es_archives mappings to have an impact on the tests.

@MadameSheema MadameSheema enabled auto-merge (squash) October 12, 2023 16:04
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 13, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 16, 2023
@MadameSheema
[Security Solution] Unskipping `x-pack/test/security_solution_cypress…
aa8b58d 
…/cypress/e2e/explore/dashboards/` working tests on serverless (elastic#167916)

(cherry picked from commit 3c4a597)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@MadameSheema MadameSheema deleted the maximizing-serverless-coverage/explore/dashboards branch October 16, 2023 14:17
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
@MadameSheema @dej611
[Security Solution] Unskipping `x-pack/test/security_solution_cypress…
01c06fe 
…/cypress/e2e/explore/dashboards/` working tests on serverless (elastic#167916)
@stephmilovic stephmilovic mentioned this pull request Dec 11, 2023
Closed
@nkhristinin nkhristinin mentioned this pull request Dec 27, 2023
Merged
nkhristinin added a commit that referenced this pull request Jan 12, 2024
@nkhristinin @kibanamachine
Unskip enrichments tests (#171983)
d43e7e5 
## Fix enrichments cypress tests

[Related PR with removing
ILM](#167916) as it not supported
in serverless. Here the
[error](https://buildkite.com/elastic/kibana-pull-request/builds/179121)
in the CI related to that

---------

Co-authored-by: Kibana Machine <[email protected]>
semd pushed a commit to semd/kibana that referenced this pull request Jan 12, 2024
@nkhristinin @kibanamachine @semd
Unskip enrichments tests (elastic#171983)
6bca15b 
## Fix enrichments cypress tests

[Related PR with removing
ILM](elastic#167916) as it not supported
in serverless. Here the
[error](https://buildkite.com/elastic/kibana-pull-request/builds/179121)
in the CI related to that

---------

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 9, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

9 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@MadameSheema MadameSheema removed backport missing Added to PRs automatically when the are determined to be missing a backport. v8.11.0 labels Jul 5, 2024
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 26, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@jbudz jbudz added the backport:skip This commit does not require backporting label Sep 30, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlie-pichette charlie-pichette charlie-pichette approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

Assignees

@MadameSheema MadameSheema

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MadameSheema @elasticmachine @kibana-ci @kibanamachine @stephmilovic @charlie-pichette @jbudz