[Alerting] Enable creating system actions through the Create Rule API #167884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
release_note:skip
2 tasks
|
Pinging @elastic/response-ops (Team:ResponseOps) |
guskovaue
reviewed
Oct 23, 2023
| @@ -181,9 +180,48 @@ export const monitoringSchema = schema.object({ | |||
| }), | |||
| }); | |||
|
|
|||
| export const rRuleSchema = schema.object({ | |||
There was a problem hiding this comment.
Why did you decide to copy this schema instead of importing it?
There was a problem hiding this comment.
This was a mistake when I resolved some conflicts with main. Fixed in 71898c9 (#167884)
|
|
||
| const data = { ...initialData, actions: addGeneratedActionValues(initialData.actions) }; | ||
| const systemActions = initialData.actions.filter( | ||
| (action): action is RuleSystemAction => action.type === RuleActionTypes.SYSTEM |
There was a problem hiding this comment.
Can we use special function for this check, we can import from here?
x-pack/plugins/alerting/common/system_actions/is_system_action.ts
There was a problem hiding this comment.
Probably some type issue.
There was a problem hiding this comment.
This is correct. The types of the createRule are not compatible with this function. I tried but I could not make it work.
x-pack/plugins/alerting/server/application/rule/methods/create/create_rule.ts
Show resolved
Hide resolved
| @@ -13,7 +13,7 @@ import { | |||
| } from '../../../lib'; | |||
| import { BASE_ALERTING_API_PATH } from '../../../../types'; | |||
| import { RouteOptions } from '../../..'; | |||
| import type { | |||
There was a problem hiding this comment.
This is a mistake. Fixed in 71898c9 (#167884)
x-pack/plugins/alerting/server/application/rule/methods/create/create_rule.ts
Outdated
Show resolved
Hide resolved
| @@ -47,8 +45,6 @@ export interface RulesClientFactoryOpts { | |||
| minimumScheduleInterval: AlertingRulesConfig['minimumScheduleInterval']; | |||
| maxScheduledPerMinute: AlertingRulesConfig['maxScheduledPerMinute']; | |||
| connectorAdapterRegistry: ConnectorAdapterRegistry; | |||
| getAlertIndicesAlias: GetAlertIndicesAlias; | |||
| alertsService: AlertsService | null; | |||
There was a problem hiding this comment.
Lost why did we delete these 2 methods from here?
There was a problem hiding this comment.
Again a mistake when fixing conflicts 🙂. Thanks! Fixed in 71898c9 (#167884)
…so_create_rule_api
…so_create_rule_api
…so_create_rule_api
guskovaue
approved these changes
Oct 24, 2023
…so_create_rule_api
This reverts commit 35153ca.
guskovaue
force-pushed
the
so_create_rule_api
branch
from
532a1c3
to
83f7167
Compare
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @cnasikas |
guskovaue
added a commit
that referenced
this pull request
Oct 27, 2023
…API (#168226) Summarize your PR. If it involves visual changes include a screenshot or gif. Depends on: #167871, #167884 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Julia Guskova <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables system actions only to the Create Rule API. Other PRs will follow on a subsequent PR.
Depends on: #167871
Related: #160367
Checklist
Delete any items that are not applicable to this PR.
For maintainers