Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make risk engine feature flags default true #167778

Merged
merged 7 commits into from
Oct 2, 2023
Merged

Make risk engine feature flags default true #167778

merged 7 commits into from
Oct 2, 2023

Conversation

nkhristinin
Copy link
Contributor

Summary

Enable feature flags true for risk engine

@nkhristinin nkhristinin requested a review from a team as a code owner October 2, 2023 13:31
@nkhristinin nkhristinin added the release_note:skip Skip the PR/issue when compiling release notes label Oct 2, 2023
@nkhristinin nkhristinin requested review from a team as code owners October 2, 2023 14:34
@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@machadoum
Copy link
Member

threat-hunting-explore code LGTM!

@nkhristinin nkhristinin requested a review from a team as a code owner October 2, 2023 17:17
MadameSheema
MadameSheema approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-engineering-productivity changes LGTM

@yctercero
Copy link
Contributor

@elasticmachine merge upstream

@ymao1
Copy link
Contributor

ymao1 commented Oct 2, 2023

I see the task manager task was added in this PR but Response Ops wasn't pinged until now bc it was behind a feature flag. We added the check_registered_task_types test so we could at least be aware of new task being added :). I took a quick look at the task definition and noticed that there is no implementation for task cancellation. Could we add a followup task for this? Otherwise, even though the task "times out" after 5m, it will actually just keep running until it's done.

@nkhristinin
Copy link
Contributor Author

I see the task manager task was added in this PR but Response Ops wasn't pinged until now bc it was behind a feature flag. We added the check_registered_task_types test so we could at least be aware of new task being added :). I took a quick look at the task definition and noticed that there is no implementation for task cancellation. Could we add a followup task for this? Otherwise, even though the task "times out" after 5m, it will actually just keep running until it's done.

Hey, I believe it was addressed here, which was merged relatively recently

ymao1
ymao1 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Response Ops changes LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nkhristinin nkhristinin merged commit 236eff4 into elastic:main Oct 2, 2023
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadameSheema MadameSheema MadameSheema approved these changes

@ymao1 ymao1 ymao1 approved these changes

@machadoum machadoum machadoum approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nkhristinin @machadoum @yctercero @ymao1 @kibana-ci @MadameSheema @kibanamachine