Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detection Engine] fixes type errors, adds category for new ES|QL rule type #167745

Merged
merged 3 commits into from
Oct 2, 2023
Merged

[Security Solution][Detection Engine] fixes type errors, adds category for new ES|QL rule type #167745

merged 3 commits into from
Oct 2, 2023

Conversation

vitaliidm
Copy link
Contributor

Summary

@vitaliidm vitaliidm self-assigned this Oct 2, 2023
@vitaliidm vitaliidm added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area v8.11.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 2, 2023
@vitaliidm vitaliidm marked this pull request as ready for review October 2, 2023 09:41
@vitaliidm vitaliidm requested a review from a team as a code owner October 2, 2023 09:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@vitaliidm vitaliidm enabled auto-merge (squash) October 2, 2023 09:57
@cnasikas cnasikas mentioned this pull request Oct 2, 2023
Merged
4 tasks
@cnasikas
Copy link
Member

cnasikas commented Oct 2, 2023 •
edited
Loading

Thanks for the fix! We also noticed the same fleet_agent_policies errors over and over again in our PR #167016.

@delanni delanni disabled auto-merge October 2, 2023 11:47
@delanni delanni merged commit 274139e into elastic:main Oct 2, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 2, 2023
@delanni
Copy link
Contributor

delanni commented Oct 2, 2023

Admin merged, to save time for developers who were blocked by this

@delanni delanni mentioned this pull request Oct 2, 2023
Closed
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #2 / Serverless Common UI - Management Create enrich policy "before all" hook for "shows create enrich policies page and docs link"
  • [job] [logs] FTR Configs #12 / serverless observability UI Observability Log Explorer Dataset Selector with installed integrations and uncategorized data streams when open on the integrations tab should display an empty prompt when the search does not match any result

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

@vitaliidm vitaliidm deleted the detection-engine/esql-category-id branch March 4, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WafaaNasr WafaaNasr WafaaNasr approved these changes

@ashokaditya ashokaditya ashokaditya approved these changes

Assignees

@vitaliidm vitaliidm

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vitaliidm @elasticmachine @cnasikas @delanni @kibana-ci @ashokaditya @WafaaNasr @kibanamachine