Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Unskip failing tests #167599

Merged
merged 1 commit into from
Sep 29, 2023
+20 −8
Merged

[Lens] Unskip failing tests #167599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/test/functional/apps/lens/group6/annotations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const from = 'Sep 19, 2015 @ 06:31:44.000';
const to = 'Sep 23, 2015 @ 18:31:44.000';

// Failing: See https://github.com/elastic/kibana/issues/167552
describe.skip('lens annotations tests', () => {
describe('lens annotations tests', () => {
before(async () => {
await PageObjects.common.setTime({ from, to });
});
Expand Down Expand Up @@ -148,6 +147,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
},
{
submit: true,
clearWithKeyboard: true,
}
);

Expand Down
4 changes: 2 additions & 2 deletions x-pack/test/functional/apps/lens/group6/lens_tagging.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const lensTag = 'extreme-lens-tag';
const lensTitle = 'lens tag test';

// Failing: See https://github.com/elastic/kibana/issues/167561
describe.skip('lens tagging', () => {
describe('lens tagging', () => {
before(async () => {
await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/logstash_functional');
await PageObjects.timePicker.setDefaultAbsoluteRangeViaUiSettings();
Expand Down Expand Up @@ -84,6 +83,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
},
{
submit: true,
clearWithKeyboard: true,
}
);

Expand Down
20 changes: 16 additions & 4 deletions x-pack/test/functional/page_objects/tag_management_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,23 @@ class TagModal extends FtrService {
* If a field is undefined, will not set the value (use a empty string for that)
* If `submit` is true, will call `clickConfirm` once the fields have been filled.
*/
async fillForm(fields: FillTagFormFields, { submit = false }: { submit?: boolean } = {}) {
async fillForm(
fields: FillTagFormFields,
{
submit = false,
clearWithKeyboard = false,
}: { submit?: boolean; clearWithKeyboard?: boolean } = {}
) {
if (fields.name !== undefined) {
await this.testSubjects.click('createModalField-name');
await this.testSubjects.setValue('createModalField-name', fields.name);
await this.testSubjects.setValue('createModalField-name', fields.name, {
clearWithKeyboard,
});
}
if (fields.color !== undefined) {
await this.testSubjects.setValue('~createModalField-color', fields.color);
await this.testSubjects.setValue('~createModalField-color', fields.color, {
clearWithKeyboard,
});
// Close the popover before moving to the next input, as it can get in the way of interacting with other elements
await this.testSubjects.existOrFail('euiSaturation');
await this.retry.try(async () => {
Expand All @@ -69,7 +79,9 @@ class TagModal extends FtrService {
}
if (fields.description !== undefined) {
await this.testSubjects.click('createModalField-description');
await this.testSubjects.setValue('createModalField-description', fields.description);
await this.testSubjects.setValue('createModalField-description', fields.description, {
clearWithKeyboard,
});
}

if (submit) {
Expand Down
Loading