-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra UI] Add missing configuration to display dotted lines in the metric charts #167509
[Infra UI] Add missing configuration to display dotted lines in the metric charts #167509
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
@@ -93,6 +93,7 @@ export const Chart = ({ | |||
filters={filters} | |||
title={title} | |||
overrides={overrides} | |||
lastReloadRequestTime={refreshTs} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensures that charts reload whenever the submit button is clicked
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
Hi @mykolaharmash , thanks for checking that. In order for the dotted lines to appear, the interval in which the metric is collected needs to be larger than the interval Lens sets in the query. The interval Lens sets increases or decreases according to the data/time interval passed into it. So if you set the date picker to a wide date range, you may not see any gaps, whereas if the range is small, it's more likely to see the gaps. That said, if the CPU is showing solid lines, it means that the query interval was able to return aggregations with data in the time buckets. When that's not the case, the dotted lines will appear: What is strange is the fact that the Network chart is much more likely to display gaps than the other charts. I don't know why and it may be that Metricbeat is taking longer than expected to report network metrics. |
Ah, I see, the granularity of the lens query was not enough to see the data gap. Thank you for the explanation 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
fixes #166850
Summary
This PR fixes a problem where the charts were not configured to display dotted lines when there were data points missing.
How to test
Infrastructure
>Hosts