Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] Add missing configuration to display dotted lines in the metric charts #167509

Merged

Conversation

crespocarlos
Copy link
Contributor

@crespocarlos crespocarlos commented Sep 28, 2023

fixes #166850

Summary

This PR fixes a problem where the charts were not configured to display dotted lines when there were data points missing.

image image

How to test

  • Setup a local Kibana instance pointing to an oblt cluster
  • Navigate to Infrastructure > Hosts
  • Click on a host to navigate to the details page
  • Verify if charts with missing data points display dottet lines

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@@ -93,6 +93,7 @@ export const Chart = ({
filters={filters}
title={title}
overrides={overrides}
lastReloadRequestTime={refreshTs}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensures that charts reload whenever the submit button is clicked

@crespocarlos crespocarlos changed the title Add missing configuration to display dotted lines in the metric charts [Infra UI] Add missing configuration to display dotted lines in the metric charts Sep 28, 2023
@crespocarlos crespocarlos added bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:ObsHosts Hosts feature within Observability v8.11.0 labels Sep 28, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #7 / Journey[many_fields_lens_editor] Open existing Lens visualization

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.0MB 2.0MB +53.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crespocarlos crespocarlos marked this pull request as ready for review September 28, 2023 14:11
@crespocarlos crespocarlos requested a review from a team as a code owner September 28, 2023 14:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@mykolaharmash
Copy link
Contributor

I've noticed that all the CPU and Memory charts still show a solid line. Should this be fixed as well? I've tested locally by stopping/starting metricbeat.

CleanShot 2023-09-28 at 17 01 42@2x

@crespocarlos
Copy link
Contributor Author

crespocarlos commented Sep 29, 2023

I've noticed that all the CPU and Memory charts still show a solid line. Should this be fixed as well? I've tested locally by stopping/starting metricbeat.

Hi @mykolaharmash , thanks for checking that.

In order for the dotted lines to appear, the interval in which the metric is collected needs to be larger than the interval Lens sets in the query. The interval Lens sets increases or decreases according to the data/time interval passed into it. So if you set the date picker to a wide date range, you may not see any gaps, whereas if the range is small, it's more likely to see the gaps.

That said, if the CPU is showing solid lines, it means that the query interval was able to return aggregations with data in the time buckets. When that's not the case, the dotted lines will appear:

image

What is strange is the fact that the Network chart is much more likely to display gaps than the other charts. I don't know why and it may be that Metricbeat is taking longer than expected to report network metrics.

@mykolaharmash
Copy link
Contributor

mykolaharmash commented Sep 29, 2023

That said, if the CPU is showing solid lines, it means that the query interval was able to return aggregations with data in the time buckets. When that's not the case, the dotted lines will appear

Ah, I see, the granularity of the lens query was not enough to see the data gap. Thank you for the explanation 🙌

Copy link
Contributor

@mykolaharmash mykolaharmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@crespocarlos crespocarlos merged commit 8c17d8a into elastic:main Sep 29, 2023
15 checks passed
@crespocarlos crespocarlos deleted the 166850-fix-charts-dotted-lines branch September 29, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature Feature:ObsHosts Hosts feature within Observability release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infra UI] Host Detail view charts not showing dotted lines when there are gaps in the data points
5 participants