[Cases] Custom fields feature fix tests #167472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js-jankisalvi
added
the
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
js-jankisalvi
added
the
release_note:skip
…js-jankisalvi/kibana into custom-fields-feature-fix-tests
adcoelho
reviewed
Sep 28, 2023
adcoelho
reviewed
Sep 28, 2023
x-pack/test/cases_api_integration/spaces_only/tests/common/cases/patch_cases.ts
Outdated
Show resolved
Hide resolved
…-ref HEAD~1..HEAD --fix'
…js-jankisalvi/kibana into custom-fields-feature-fix-tests
adcoelho
reviewed
Sep 28, 2023
semd
approved these changes
Sep 28, 2023
banderror
approved these changes
Sep 28, 2023
cnasikas
reviewed
Sep 29, 2023
| @@ -495,31 +495,11 @@ describe('create', () => { | |||
| ); | |||
| }); | |||
|
|
|||
| it('should not throw an error and fill out missing customFields when they are undefined', async () => { | |||
There was a problem hiding this comment.
I think we should keep this test and the new test you added ("should throw an error when required `customFields are undefined"). For this test, we need to make all fields in the configuration optional.
| if (customFieldsConfiguration === undefined) { | ||
| throw Boom.badRequest('No custom fields configured.'); | ||
| if (!Array.isArray(requestCustomFields) || !requestCustomFields.length) { |
There was a problem hiding this comment.
I am a bit confused about this change. What scenario are we trying to cover?
There was a problem hiding this comment.
This is strange, this doesn't seem to be my change 😄
There was a problem hiding this comment.
It seems that @adcoelho tried to fix some tests in f10dd1b (#167472)
There was a problem hiding this comment.
I think that if there is no configuration or no custom fields we should return. The function validates only required custom fields so no configuration means no custom fields are required.
There was a problem hiding this comment.
We discussed offline and we decided to leave it as it is.
| @@ -50,7 +50,7 @@ export default ({ getService }: FtrProviderContext): void => { | |||
| }); | |||
|
|
|||
| it('should resolve a case with no comments', async () => { | |||
| const postedCase = await createCase(supertest, getPostCaseRequest()); | |||
| const postedCase = await createCase(supertest, postCaseReq); | |||
There was a problem hiding this comment.
I assume that because the getPostCaseRequest() has customFields failed. I think we should getPostCaseRequest and not add the customFields in getPostCaseRequest. See my previous comment.
There was a problem hiding this comment.
Actually here I am not sure what was wrong because the test passed in local and failed in pipeline
cnasikas
added
ci:cloud-deploy
…-ref HEAD~1..HEAD --fix'
…js-jankisalvi/kibana into custom-fields-feature-fix-tests
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Saved Objects .kibana field count
History
To update your PR or re-run it, just comment with: |
cnasikas
approved these changes
Sep 29, 2023
js-jankisalvi
merged commit 60cdab5
into
elastic:cases-custom-fields-feature-branch
1 check passed
js-jankisalvi
added a commit
that referenced
this pull request
Oct 2, 2023
## Summary
This PR implements an MPV for custom fields in Cases. Specifically:
- Users can add, delete, or edit custom fields from the configuration
page
- Users can set custom fields when creating a case
- Users can set custom fields when editing a case
- Only the `Text` custom field type is supported. The `Toggle` is
implemented to test the framework.
- Users with a basic license can enter the configuration page and set
custom fields
- The configuration page header changed to "Settings"
- The "Edit external connection" button changed to "Settings"
- APIs:
- Users cannot post custom fields with duplicate keys
- Users cannot change the type of the custom field
- Users cannot add custom fields that are not configured
- Required fields should be present
- If some of the custom fields are omitted from the request the backend
will fill them with `null` values
- Limits:
- Maximum 10 custom fields configured
- Maximum 50 chars in custom field labels
- Maximum 160 chars for the value of the `Text` custom field type
- Users cannot change the type of a custom field
- The key of the custom fields should contain only lowercase letters
(a-z), numbers (0-9), '_', and '-'
- Required fields needs a value
## Testing
- Cases created before custom fields are working as expected (create
some on `main` before switching to the feature branch)
- Environments without configuration are working as expected (clear ES
data)
- Environments with existing configurations are working as expected
- Try to create cases with custom fields (required & optional) and
delete some of them
- Try to create cases with custom fields (required & optional) and then
configure new custom fields. Existing cases with old custom fields
should work as expected
- User actions are working as expected especially with the combinations
described in the previous two bullets
- Users with a basic license can configure custom fields but cannot
configure connectors
- Users with a gold+ license can configure custom fields and connectors
- Users with read access cannot configure or edit custom fields
Resolves: #160236
PRs:
- #165671
- #166353
- #166439
- #166483
- #166815
- #166940
- #166962
- #166969
- #166975
- #167029
- #167047
- #167105
- #167131
- #167144
- #167166
- #167167
- #167310
- #167386
- #167481
- #167495
- #167398
- #167472
### Checklist
Delete any items that are not applicable to this PR.
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
### For maintainers
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
## Release notes
Allow users to configure custom fields in Cases. Supported field types:
Text. Coming soon: Multi-text, List, Number, Toggle, Date, IP, Email,
etc.
---------
Co-authored-by: adcoelho <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Christos Nasikas <[email protected]>
Co-authored-by: Julian Gernun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Connected to #160236
This PR fixes tests for custom field mvp feature
Checklist