Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some type issues for APM UI #167347

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Fix some type issues for APM UI #167347

merged 1 commit into from
Sep 27, 2023

Conversation

Ikuni17
Copy link
Contributor

@Ikuni17 Ikuni17 commented Sep 26, 2023 •
edited
Loading

Summary

We're breaking #166813 up into smaller PRs in the interest of getting PRs through sooner for type fixes. These are the changes for APM UI.

@Ikuni17 Ikuni17 added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.11.0 labels Sep 26, 2023
@Ikuni17 Ikuni17 requested a review from a team as a code owner September 26, 2023 20:55
@Ikuni17 Ikuni17 self-assigned this Sep 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@Ikuni17 Ikuni17 changed the title Pick APM UI from #166813 Fix some type issues for APM UI Sep 26, 2023
@Ikuni17 Ikuni17 enabled auto-merge (squash) September 26, 2023 21:26
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #68 / maps app embeddable maps add-to-dashboard save flow should allow existing maps be added by reference to an existing dashboard

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observabilityOnboarding 14 16 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 239.4KB 239.4KB +10.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityOnboarding 5.6KB 5.5KB -57.0B
Unknown metric groups

API count

id before after diff
observabilityOnboarding 14 17 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @delanni @Ikuni17

sorenlouv
sorenlouv approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ikuni17 Ikuni17 merged commit 7a87c36 into elastic:main Sep 27, 2023
11 checks passed
@Ikuni17 Ikuni17 deleted the fix/apm-ui-types branch February 9, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@delanni delanni

@Ikuni17 Ikuni17

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Operations Team label for Operations Team v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ikuni17 @elasticmachine @kibana-ci @sorenlouv @delanni