-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs onboarding] fixing type issues #167340
[Logs onboarding] fixing type issues #167340
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
...plugins/observability_onboarding/public/components/app/custom_logs/install_elastic_agent.tsx
Outdated
Show resolved
Hide resolved
...plugins/observability_onboarding/public/components/app/custom_logs/install_elastic_agent.tsx
Outdated
Show resolved
Hide resolved
…kibana into fixing-onboarding-type-problems
@yngrdyn Did the original change made it to 8.10 ? If yes, then this would require backporting |
No, these changes were introduced last week @achyutjhunjhunwala |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: |
OBSERVABILITY_ONBOARDING_LOCATOR
andObservabilityOnboardingLocatorParams
were removed fromobservability_onboarding
plugin in #165962 and are now part of@kbn/deeplinks-observability/locators
.datsetName
was transformed into an optional variable in the wizard state in #166654 which makes sense for first step of custom logs onboarding but it's required in onboarding saved object.