-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add telemetry for toasts 166459 2 #167270
Feat/add telemetry for toasts 166459 2 #167270
Conversation
fix test expectation
consolidate toast dismisal to one single metric
Pinging @elastic/appex-sharedux (Team:SharedUX) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Page load bundle
To update your PR or re-run it, just comment with: |
Original PR: #166466
Closes #166466
Original:
Summary
Address #166459
This PR scaffolds telemetry into the notification service, to enable reporting when deduped toasts are dismissed. When a deduped toast is dismissed; the message recurrence count and the toast message would be emitted.
Telemetry Event Definition;
Testing;
visualize library
from the global search bar, and navigate to visualize library.TSVB
visualization type. At this step there typically wouldn't be an error/internal/metrics/vis/data
like soon doing this, we then attempt refreshing the query, we would then be presented with an error toast, similar to the screenshot below;
click the refresh query button as much as you like to increase it's recurrence count.
kibana_browser
with a payload containing the telemetry event definition above.Checklist