Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAM] Correct renamed function after a race-condition merge #167026

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Sep 22, 2023

Summary

There was an accidental race-condition on a variable re-name and usage between #166032 & #166603.

This PR intends to correct that.

@delanni delanni requested a review from a team as a code owner September 22, 2023 11:06
@delanni delanni added release_note:skip Skip the PR/issue when compiling release notes v8.10.0 backport Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Sep 22, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 22, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #58 / detection engine api security and spaces enabled - Prebuilt Rules install_prebuilt_rules_from_real_package should install prebuilt rules from the package storage
  • [job] [logs] FTR Configs #58 / detection engine api security and spaces enabled - Prebuilt Rules install_prebuilt_rules_from_real_package should install prebuilt rules from the package storage

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@delanni delanni merged commit e2a7157 into elastic:main Sep 22, 2023
9 checks passed
@delanni
Copy link
Contributor Author

delanni commented Sep 22, 2023

Merged despite a flaky test, this should not be related to this fix.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 22, 2023
…167026)

## Summary
There was an accidental race-condition on a variable re-name and usage
between elastic#166032 &
elastic#166603.

This PR intends to correct that.

(cherry picked from commit e2a7157)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@delanni delanni deleted the fix-missed-rename branch May 2, 2024 11:27
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 22, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@delanni delanni added the backport:skip This commit does not require backporting label May 27, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting backport release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.0 v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants