Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Fixes error in new metric when breakdown is a number #167018

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

stratoula
Copy link
Contributor

Summary

In ES|QL we don't have field formatters. We just have the type of the field (number/date etc).

If you are in Discover and write a query which returns only one column/row then the new metric is suggested.

image

If for whatever reason the user goes to breakdown and selects the same number variable (try_new) the chart will fail to render and you will see in the console an error.

This happens because EC wait the title to be string but here as we don't have field formatters this is number and fails.

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana v8.11.0 labels Sep 22, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionMetricVis 4.6KB 4.6KB +8.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 22, 2023
@stratoula stratoula marked this pull request as ready for review September 22, 2023 12:09
@stratoula stratoula requested a review from a team as a code owner September 22, 2023 12:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only 👍

@stratoula stratoula merged commit 884bcb2 into elastic:main Sep 22, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants