[Osquery][Defend Workflows] No responses for alert on flyout #166916
Conversation
szwarckonrad
added
v8.10.0
v8.11.0
Team:Defend Workflows
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
| ) : ( | ||
| <FormattedMessage | ||
| id="xpack.securitySolution.eventDetails.responseActionsViewNoActions" | ||
| defaultMessage="No responses are available for this alert." |
There was a problem hiding this comment.
you might want to use this sentence (from the new expandable flyout overview section or this one (from the new expandable flyout detailed section).
They've both been reviewed and approved by docs. Plus we'd have consistency between the 2 flyouts?
There was a problem hiding this comment.
@nastasha-solomon what do you think?
There was a problem hiding this comment.
Sorry, I missed this yesterday @PhilippeOberti. Where's this message appearing? Is it in the right and left panels, or only one place?
RE the actual message: Some minor edits to make the voice active and to clarify that we're talking about response actions only.
There was a problem hiding this comment.
@nastasha-solomon unless I'm mistaken this would appear in the left section only (and in the old flyout).
Any reason you would not want to go with one of the options I mentioned in my comment? We're already using these options in the new flyout
There was a problem hiding this comment.
Actually, both of those are perfect. Sorry about that! I must've missed the first comment.
There was a problem hiding this comment.
@szwarckonrad can you make the change? (see values in my first comment)
… into fix-osquery-no-response-actions
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…#166916) elastic#166040 Inform user that there are no responses associated with and alert instead of returning `null`.  (cherry picked from commit c7bb851)
…166916) (#167602) # Backport This will backport the following commits from `main` to `8.10`: - [[Osquery][Defend Workflows] No responses for alert on flyout (#166916)](#166916) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Konrad Szwarc","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-29T08:17:30Z","message":"[Osquery][Defend Workflows] No responses for alert on flyout (#166916)\n\nhttps://github.com//issues/166040\r\n\r\nInform user that there are no responses associated with and alert\r\ninstead of returning `null`.\r\n\r\n","sha":"c7bb851ded898f0a64f3ad9d0618c954e20a78de","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","Osquery","v8.11.0","v8.10.3"],"number":166916,"url":"https://github.com/elastic/kibana/pull/166916","mergeCommit":{"message":"[Osquery][Defend Workflows] No responses for alert on flyout (#166916)\n\nhttps://github.com//issues/166040\r\n\r\nInform user that there are no responses associated with and alert\r\ninstead of returning `null`.\r\n\r\n","sha":"c7bb851ded898f0a64f3ad9d0618c954e20a78de"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/166916","number":166916,"mergeCommit":{"message":"[Osquery][Defend Workflows] No responses for alert on flyout (#166916)\n\nhttps://github.com//issues/166040\r\n\r\nInform user that there are no responses associated with and alert\r\ninstead of returning `null`.\r\n\r\n","sha":"c7bb851ded898f0a64f3ad9d0618c954e20a78de"}},{"branch":"8.10","label":"v8.10.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Konrad Szwarc <[email protected]>
#166040
Inform user that there are no responses associated with and alert instead of returning
null.