Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] expandable flyout - add tooltip to correlations table cells #166913

Conversation

PhilippeOberti
Copy link
Contributor

@PhilippeOberti PhilippeOberti commented Sep 21, 2023

Summary

This PR adds a tooltip to the table cells for the Security Solution expandable flyout left panel correlations tables:

  • related cases
  • related alerts by ancestry
  • related alerts by source event
  • related alerts by session
Screen.Recording.2023-09-21.at.10.35.23.AM.mov

#164983

Checklist

@PhilippeOberti PhilippeOberti force-pushed the expandable-flyout-correlations-table-tooltip branch from b9d2cf5 to f390669 Compare September 21, 2023 16:17
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4544 4545 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.7MB 12.8MB +1.4KB

History

  • 💔 Build #160655 failed b9d2cf5a8831559c344e58947afea46e9de9edaf

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@PhilippeOberti PhilippeOberti merged commit b4d8f6e into elastic:main Sep 22, 2023
@PhilippeOberti PhilippeOberti deleted the expandable-flyout-correlations-table-tooltip branch September 22, 2023 06:47
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.10 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 166913

Questions ?

Please refer to the Backport tool documentation

@PhilippeOberti
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

PhilippeOberti added a commit to PhilippeOberti/kibana that referenced this pull request Sep 27, 2023
…able cells (elastic#166913)

(cherry picked from commit b4d8f6e)

# Conflicts:
#	x-pack/plugins/security_solution/public/flyout/left/components/correlations_details_alerts_table.tsx
#	x-pack/plugins/security_solution/public/flyout/left/components/related_cases.tsx
PhilippeOberti added a commit that referenced this pull request Sep 27, 2023
…tions table cells (#166913) (#167413)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Security Solution] expandable flyout - add tooltip to correlations
table cells (#166913)](#166913)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-22T06:46:50Z","message":"[Security
Solution] expandable flyout - add tooltip to correlations table cells
(#166913)","sha":"b4d8f6ef51967f05e026224674e8177d864a1fef","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat
Hunting:Investigations","v8.11.0","v8.10.3"],"number":166913,"url":"https://github.com/elastic/kibana/pull/166913","mergeCommit":{"message":"[Security
Solution] expandable flyout - add tooltip to correlations table cells
(#166913)","sha":"b4d8f6ef51967f05e026224674e8177d864a1fef"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/166913","number":166913,"mergeCommit":{"message":"[Security
Solution] expandable flyout - add tooltip to correlations table cells
(#166913)","sha":"b4d8f6ef51967f05e026224674e8177d864a1fef"}},{"branch":"8.10","label":"v8.10.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants