Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Fix layout padding #166837

Merged
merged 4 commits into from
Sep 20, 2023
Merged

[Fleet] Fix layout padding #166837

merged 4 commits into from
Sep 20, 2023

Conversation

nchaulet
Copy link
Member

Summary

Fix layout padding to work well in serverless

Before

Screenshot 2023-09-20 at 10 03 27 AM

After

Screenshot 2023-09-20 at 10 05 24 AM

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Sep 20, 2023
@nchaulet nchaulet requested a review from a team as a code owner September 20, 2023 14:05
@nchaulet nchaulet self-assigned this Sep 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet nchaulet enabled auto-merge (squash) September 20, 2023 14:59
@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet nchaulet merged commit 1220da7 into elastic:main Sep 20, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +87.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Sep 20, 2023
gergoabraham pushed a commit to gergoabraham/kibana that referenced this pull request Sep 21, 2023
@nchaulet @gergoabraham
[Fleet] Fix layout padding (elastic#166837)
0a396ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@criamico criamico criamico approved these changes

@hop-dev hop-dev hop-dev approved these changes

Assignees

@nchaulet nchaulet

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nchaulet @elasticmachine @apmmachine @kibana-ci @hop-dev @criamico @kibanamachine