Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Add versioned router for timelines #7144 #166729

Merged
merged 3 commits into from
Oct 3, 2023
Merged

[Security Solution] Add versioned router for timelines #7144 #166729

merged 3 commits into from
Oct 3, 2023

Conversation

lgestc
Copy link
Contributor

@lgestc lgestc commented Sep 19, 2023 •
edited
Loading

Summary

This PR introduces versioned router for timeline apis, as per https://github.com/elastic/security-team/issues/7144

The change itself is rather minimal but should still be reviewed carefully.

Thanks!

@lgestc lgestc added Team:Threat Hunting:Investigations Security Solution Investigations Team 8.11 candidate v8.11.0 release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Sep 19, 2023
@lgestc
Copy link
Contributor Author

lgestc commented Sep 19, 2023

@XavierM @angorayc I would really appreciate your input guys!

@lgestc lgestc marked this pull request as ready for review September 19, 2023 15:37
@lgestc lgestc requested a review from a team as a code owner September 19, 2023 15:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@lgestc lgestc force-pushed the versioned_router_for_timelines branch from 826aca4 to 41bdd8c Compare September 19, 2023 16:05
@lgestc lgestc changed the title add versioned router for timelines #7144 [Security Solution] Add versioned router for timelines #7144 Sep 19, 2023
@angorayc
Copy link
Contributor

Hello @lgestc , thanks for the enhancement. I found some error while interacting with timelines and draft timelines:

draft_timeline pre_packaged_timeline Screenshot 2023-09-21 at 18 23 02 Screenshot 2023-09-21 at 18 24 37 Screenshot 2023-09-21 at 18 24 45

@lgestc lgestc force-pushed the versioned_router_for_timelines branch from 41bdd8c to 3953e25 Compare September 22, 2023 12:30
@lgestc
Copy link
Contributor Author

lgestc commented Sep 22, 2023

Hello @lgestc , thanks for the enhancement. I found some error while interacting with timelines and draft timelines:

draft_timeline pre_packaged_timeline Screenshot 2023-09-21 at 18 23 02 Screenshot 2023-09-21 at 18 24 37 Screenshot 2023-09-21 at 18 24 45

thanks for the heads up, I guess that version header is mandatory after all.

@lgestc lgestc force-pushed the versioned_router_for_timelines branch from 6a9dc00 to 692acd0 Compare September 27, 2023 15:42
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.0MB 13.0MB +1.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lgestc

michaelolo24
michaelolo24 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM!

@lgestc lgestc merged commit d1e13ef into elastic:main Oct 3, 2023
29 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

@angorayc angorayc Awaiting requested review from angorayc

@XavierM XavierM Awaiting requested review from XavierM

Assignees

@lgestc lgestc

Labels
8.11 candidate backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lgestc @elasticmachine @angorayc @kibana-ci @michaelolo24 @kibanamachine