Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming the esre application into ai_search #166632

Merged
merged 17 commits into from
Sep 20, 2023
Merged

Renaming the esre application into ai_search #166632

merged 17 commits into from
Sep 20, 2023

Conversation

afoucret
Copy link
Contributor

@afoucret afoucret commented Sep 18, 2023 •
edited
Loading

Summary

ELSER v2 and the inference API changes are coming in 8.11 – we can make a few UI changes to accommodate, inform, and help boost adoption.

This PR contains:

  • Renamed the esre application to ai_search
  • Search AI guide improvements (formerly ESRE guide)
  • New sidebar

TODO:

  • all telemetry labels have been updated as part of of. To be checked with @aznick
  • check for Japanese and Chinese translations

Screenshots

Capture d’écran 2023-09-19 à 15 51 13 Capture d’écran 2023-09-19 à 15 51 55

Checklist

Delete any items that are not applicable to this PR.

@afoucret afoucret force-pushed the search-ai-ui-changes branch from 5bedffe to 0bbbd8e Compare September 18, 2023 14:30
@afoucret afoucret force-pushed the search-ai-ui-changes branch from 96e6d9e to 9e3c312 Compare September 18, 2023 14:36
@afoucret afoucret force-pushed the search-ai-ui-changes branch 2 times, most recently from 8b85042 to 8f62685 Compare September 18, 2023 16:42
@afoucret afoucret added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.11.0 labels Sep 19, 2023
@afoucret afoucret marked this pull request as ready for review September 19, 2023 14:06
@afoucret afoucret requested a review from a team September 19, 2023 14:06
@afoucret afoucret requested review from a team as code owners September 19, 2023 14:06
@afoucret afoucret requested a review from a team September 19, 2023 14:06
@afoucret afoucret requested a review from a team as a code owner September 19, 2023 14:06
sphilipse
sphilipse approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a LOT but I don't see any issues so LGTM!

leemthompo
leemthompo approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc links changes LGTM

@kc13greiner kc13greiner self-requested a review September 19, 2023 17:25
kc13greiner
kc13greiner approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@afoucret
Copy link
Contributor Author

Hey @elastic/platform-onboarding, it would be great if someone has some time to review this.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #27 / serverless search UI Importing an existing dashboard "before all" hook for "should be able to import dashboard created in 8.11"

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/doc-links 73 74 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +299.0B
home 164.2KB 164.2KB +2.0B
lists 146.6KB 146.7KB +85.0B
total +386.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 365.8KB 365.9KB +85.0B
enterpriseSearch 39.8KB 39.9KB +111.0B
total +196.0B
Unknown metric groups

API count

id before after diff
@kbn/doc-links 73 74 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afoucret afoucret merged commit c12276d into elastic:main Sep 20, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 20, 2023
@afoucret afoucret deleted the search-ai-ui-changes branch September 20, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aznick aznick aznick left review comments

@sphilipse sphilipse sphilipse approved these changes

@bollinic bollinic bollinic approved these changes

@leemthompo leemthompo leemthompo approved these changes

@kc13greiner kc13greiner kc13greiner approved these changes

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@afoucret @kibana-ci @pgayvallet @TattdCodeMonkey @aznick @kc13greiner @leemthompo @bollinic @sphilipse @kibanamachine