[Synthetics] Refactor cardinality test runs query #166608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
shahzad31
added
release_note:skip
awahab07
requested changes
Sep 21, 2023
There was a problem hiding this comment.
I had all my monitors disabled while on the main branch:
I switched to the PR branch and the number was slightly down:
The above may not be an issue as the count decrease is insignificant. But I've noticed that the query for both the count and series is not filtering for synthetics.type: "heartbeat/summary".
Doc count without synthetics.type: "heartbeat/summary":
Doc count with synthetics.type: "heartbeat/summary":
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
… into query-permormance
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
shahzad31
added
v8.10.3
and removed
backport:skip
shahzad31
added
the
auto-backport
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Sep 28, 2023
(cherry picked from commit 59c5eb0)
shahzad31
added a commit
that referenced
this pull request
Oct 3, 2023
…167547) # Backport This will backport the following commits from `main` to `8.10`: - [[Synthetics] Refactor cardinality test runs query (#166608)](#166608) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-26T10:12:24Z","message":"[Synthetics] Refactor cardinality test runs query (#166608)","sha":"59c5eb0988c61dfd5f589e656dc4096102eade33","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","auto-backport","v8.11.0","v8.10.3"],"number":166608,"url":"https://github.com/elastic/kibana/pull/166608","mergeCommit":{"message":"[Synthetics] Refactor cardinality test runs query (#166608)","sha":"59c5eb0988c61dfd5f589e656dc4096102eade33"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/166608","number":166608,"mergeCommit":{"message":"[Synthetics] Refactor cardinality test runs query (#166608)","sha":"59c5eb0988c61dfd5f589e656dc4096102eade33"}},{"branch":"8.10","label":"v8.10.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor cardinality test runs query !!
Testing
Test result count should remain same after/before PR on a data