Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused d3-cloud library #166601

Merged
merged 6 commits into from
Sep 26, 2023
Merged

Remove unused d3-cloud library #166601

merged 6 commits into from
Sep 26, 2023

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Sep 18, 2023 •
edited
Loading

Summary

This PR removes the d3-cloud library specified as a dependency in Kibana package.json
The current tag-cloud uses the d3-cloud version library that is a dependency of elastic-charts.

@markov00 markov00 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes dependencies Pull requests that update a dependency file labels Sep 20, 2023
@markov00 markov00 marked this pull request as ready for review September 20, 2023 10:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@markov00 markov00 requested a review from a team September 20, 2023 10:03
dej611
dej611 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that nobody else is using it 👍
Code review only

@stratoula stratoula enabled auto-merge (squash) September 26, 2023 09:50
@stratoula stratoula merged commit a8de9eb into elastic:main Sep 26, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #46 / serverless security UI Create Case "before all" hook for "creates a case"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

@dej611 dej611 dej611 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting dependencies Pull requests that update a dependency file release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@markov00 @elasticmachine @kibana-ci @dej611 @nickofthyme @stratoula @kibanamachine