-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Actions] System actions MVP #166267
Merged
Merged
[Actions] System actions MVP #166267
Changes from all commits
Commits
Show all changes
147 commits
Select commit
Hold shift + click to select a range
29973e2
[Actions] Connector Adapters MVP (#166101)
cnasikas 10e2a56
Merge branch 'main' into system_actions_mvp
cnasikas 1bb0eb5
Merge branch 'main' into system_actions_mvp
cnasikas dac21c2
Merge branch 'main' into system_actions_mvp
cnasikas d5f1791
[Actions] Expose `getAllSystemActions` from the actions client (#167783)
cnasikas d465407
Merge branch 'main' into system_actions_mvp
cnasikas a6d9da4
Merge branch 'system_actions_mvp' of github.com:elastic/kibana into s…
cnasikas b064eba
Merge branch 'main' into system_actions_mvp
cnasikas 6923ae2
[Alerting] System action types and helpers (#167871)
cnasikas a291f7a
Merge branch 'main' into system_actions_mvp
cnasikas 8dedac8
[Alerting] Enable creating system actions through the Create Rule API…
cnasikas 861697c
Merge branch 'main' into system_actions_mvp
guskovaue 645e45c
Merge branch 'system_actions_mvp' of github.com:elastic/kibana into s…
guskovaue a271f50
[Alerting] Enable updating system actions through the Bulk Edit Rule …
cnasikas bb0ad08
Merge branch 'main' into system_actions_mvp
guskovaue f7ecb3b
Merge branch 'system_actions_mvp' of github.com:elastic/kibana into s…
guskovaue 62ba292
[RAM] System action in bulk disable api (#170229)
guskovaue c0b2feb
Merge branch 'main' into system_actions_mvp
guskovaue aadd675
[RAM] System action in bulk enable api (#170476)
guskovaue 825bcc6
Merge branch 'main' into system_actions_mvp
guskovaue 6105ee6
Merge branch 'system_actions_mvp' of github.com:elastic/kibana into s…
guskovaue d8a7569
[RAM] System action in bulk delete (#170741)
guskovaue f2f6f7d
[RAM] System actions update rule api (#171099)
guskovaue f8a1a73
Merge remote-tracking branch 'upstream/main' into system_actions_mvp
Zacqary 21f0a78
[System Actions] Complete API audit and update APIs to comply with Sy…
Zacqary 299142c
[RAM] Add example log system action type (#175057)
Zacqary 72fa37e
Merge branch 'main' of github.com:elastic/kibana into system_actions_mvp
XavierM 18f0b14
Merge branch 'main' of github.com:elastic/kibana into system_actions_mvp
XavierM e8a817e
Merge branch 'system_actions_mvp' of github.com:elastic/kibana into s…
XavierM 9777b7f
Merge branch 'main' into system_actions_mvp
kibanamachine 00fdb26
fix multiple identifier
XavierM 83bcec5
Merge branch 'system_actions_mvp' of github.com:elastic/kibana into s…
XavierM b093407
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 80efe3f
First round of type fixes for triggers_actions_ui
Zacqary 1077624
Merge branch 'system_actions_mvp' of https://github.com/elastic/kiban…
Zacqary c93530e
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 3211810
fix some types
XavierM 43e5601
Merge branch 'system_actions_mvp' of github.com:elastic/kibana into s…
XavierM 084c6c0
Fix test typechecks in triggers_actions_ui
Zacqary c6ea491
Fix hook linting issues
Zacqary 942a32e
Merge branch 'system_actions_mvp' of https://github.com/elastic/kiban…
Zacqary 9e125c0
Fix alerting plugin typecheck
Zacqary 98f79c8
Fix linting
Zacqary b34fa44
Merge remote-tracking branch 'upstream/main' into system_actions_mvp
Zacqary f474d40
Fix create_rule bad merge
Zacqary 87dd315
Fix jest snapshots
Zacqary 62855f0
Fix Jest
Zacqary 011bd79
fix more types
XavierM 4508ad8
Merge branch 'system_actions_mvp' of github.com:elastic/kibana into s…
XavierM e2f3ebc
rmv filterStateStore from alerting plugin to use @kbn/es-query
XavierM 3342d89
Fix create_rule jest and others
Zacqary e2f2d4a
Fix snapshots
Zacqary e91c248
Merge branch 'system_actions_mvp' of https://github.com/elastic/kiban…
Zacqary a755eb3
fix more types
XavierM b4958aa
Merge branch 'system_actions_mvp' of github.com:elastic/kibana into s…
XavierM 88e40ab
last types issues
XavierM f68b6ab
Fix jest and snapshots
Zacqary 3b54609
Fix lint
Zacqary 45801a4
Fix snapshot
Zacqary eea8f33
Merge remote-tracking branch 'upstream/main' into system_actions_mvp
Zacqary 7ebda8e
fix types in alerting plugin
XavierM 0ec37f9
Merge branch 'system_actions_mvp' of github.com:elastic/kibana into s…
XavierM 7e5273c
Fix createRule schema validation errors
Zacqary 2ac6f9a
Merge branch 'system_actions_mvp' of https://github.com/elastic/kiban…
Zacqary b9bbc02
Fix tests and action validation
Zacqary 27d7de9
Merge branch 'main' of github.com:elastic/kibana into system_actions_mvp
XavierM 438afbc
add systemActions attribute in alert plugins
XavierM b1c3105
Merge branch 'main' of github.com:elastic/kibana into system_actions_mvp
XavierM 4c1201a
Merge branch 'main' of github.com:elastic/kibana into system_actions_mvp
XavierM a85f319
fix triggers action UI types
XavierM 3f931b0
Merge branch 'main' of github.com:elastic/kibana into system_actions_mvp
XavierM 9156355
fix create validation
XavierM a799f07
fix few broken code whoopsie
XavierM 5c00493
Merge branch 'main' of github.com:elastic/kibana into system_actions_mvp
XavierM 529a237
not proud of this
XavierM 68ade8e
part I fixing jest test
XavierM 2c18746
Fix jest tests part 2
cnasikas 8b7315b
Change paths for system connectors
cnasikas 5cd185d
Add integration tests for actions routes
cnasikas 9c624ef
Merge branch 'main' into system_actions_mvp
cnasikas 589cd31
green jest test for alerting plugin
XavierM cfeb4bf
Merge branch 'system_actions_mvp' of github.com:elastic/kibana into s…
XavierM 4e8be7c
green jest test for trigers_action_ui plugin
XavierM efd576b
Merge branch 'main' into system_actions_mvp
XavierM c13c7c7
no changes in security solution plugin
XavierM 7b8197b
Merge branch 'main' of github.com:elastic/kibana into system_actions_mvp
XavierM 43fe179
Merge branch 'system_actions_mvp' of github.com:elastic/kibana into s…
XavierM 88a4eac
remove systemAction from revision
XavierM 6f2e655
Merge branch 'main' of github.com:elastic/kibana into system_actions_mvp
XavierM b352633
fix few FTR
XavierM 36cf4c5
fix legacy FTR
XavierM 75ac3c7
Fix FTR legacy 2
XavierM 1863c78
christos review
XavierM ab4289b
fix system action FTR
XavierM 24ef9d7
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 2046bf2
few more FTR tests
XavierM 71d6a9c
Merge branch 'system_actions_mvp' of github.com:elastic/kibana into s…
XavierM 4ceb9b5
Merge branch 'main' of github.com:elastic/kibana into system_actions_mvp
XavierM 3b418e9
left over of use_alert_data_for_template
XavierM 3338150
fix type for isActionExecutable
XavierM 9f9e90a
review + fix synthetic FTR
XavierM 2e3306e
fix jest tests
XavierM 3805a98
fix reducer
XavierM 267e641
Merge branch 'main' of github.com:elastic/kibana into system_actions_mvp
XavierM a6f5742
fix bad merge
XavierM 97399f0
fix last jest test + security solution
XavierM 6dcfb7b
Fix bulk_edit_rules unit test
cnasikas 73a6e40
clean up execution handler
XavierM 8455a28
Merge branch 'system_actions_mvp' of github.com:elastic/kibana into s…
XavierM c87b180
Add more tests
cnasikas 73f2799
Merge branch 'system_actions_mvp' of github.com:elastic/kibana into s…
cnasikas 6e0e27f
rmv unused components
XavierM e3a18f3
Merge branch 'main' of github.com:elastic/kibana into system_actions_mvp
XavierM 0501088
Create seperate action form component for system actions
cnasikas e4328eb
Merge branch 'main' into system_actions_mvp
cnasikas ea73310
Delete unused test file
cnasikas 2c8d9b9
Fix types
cnasikas 30ac0a4
Rename component
cnasikas d035b71
Fix merge with main
cnasikas 2ee86d0
Add tests for system action form
cnasikas ab0302c
Rename routes and improve tests
cnasikas 56fa5d7
PR feedback v1
cnasikas 8d401d2
PR feedback v2
cnasikas c958f5b
Throw an error if the group is not defined when creating an alert wit…
cnasikas 71662af
Throw an error if the group is not defined when updating an alert wit…
cnasikas 00982d1
Throw an error if the group is not defined when bulk editing an alert…
cnasikas 88ad5eb
Merge branch 'main' into system_actions_mvp
cnasikas 8c90074
Add more unit tests
cnasikas 69e2965
Merge branch 'main' into system_actions_mvp
cnasikas 5e84c05
Add tests for rule clients methods
cnasikas ec8536a
Add integration tests
cnasikas 38123e9
Merge branch 'main' into system_actions_mvp
cnasikas f2f9827
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 3685ebc
Fix type error
cnasikas a2b0cc0
Do not allow the execution of system actions through the execute API
cnasikas eea2743
Merge branch 'system_actions_mvp' of github.com:elastic/kibana into s…
cnasikas 6c1317b
Throw an error if a system action is used twice
cnasikas 57559e6
Remove rules after the end of tests
cnasikas 91eb80c
Fix integration tests
cnasikas d1ba533
Merge branch 'main' into system_actions_mvp
cnasikas c38cebc
Disable system action type if already selected
cnasikas e59c542
Fix type errors in integration tests
cnasikas c5c06e9
Type connector adapter params
cnasikas eb96022
Merge branch 'main' into system_actions_mvp
kibanamachine 763e05f
PR feedback
cnasikas 2cf8246
Merge branch 'main' into system_actions_mvp
cnasikas bcc2397
PR feedback 2
cnasikas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
...ggers_actions_ui_example/public/connector_types/system_log_example/system_log_example.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { lazy } from 'react'; | ||
import { i18n } from '@kbn/i18n'; | ||
import type { | ||
ActionTypeModel as ConnectorTypeModel, | ||
GenericValidationResult, | ||
} from '@kbn/triggers-actions-ui-plugin/public/types'; | ||
import { SystemLogActionParams } from '../types'; | ||
|
||
export function getConnectorType(): ConnectorTypeModel<unknown, unknown, SystemLogActionParams> { | ||
return { | ||
id: '.system-log-example', | ||
iconClass: 'logsApp', | ||
selectMessage: i18n.translate( | ||
'xpack.stackConnectors.components.systemLogExample.selectMessageText', | ||
{ | ||
defaultMessage: 'Example of a system action that sends logs to the Kibana server', | ||
} | ||
), | ||
actionTypeTitle: i18n.translate( | ||
'xpack.stackConnectors.components.serverLog.connectorTypeTitle', | ||
{ | ||
defaultMessage: 'Send to System log - Example', | ||
} | ||
), | ||
validateParams: ( | ||
actionParams: SystemLogActionParams | ||
): Promise<GenericValidationResult<Pick<SystemLogActionParams, 'message'>>> => { | ||
const errors = { | ||
message: new Array<string>(), | ||
}; | ||
const validationResult = { errors }; | ||
if (!actionParams.message?.length) { | ||
errors.message.push( | ||
i18n.translate( | ||
'xpack.stackConnectors.components.serverLog.error.requiredServerLogMessageText', | ||
{ | ||
defaultMessage: 'Message is required.', | ||
} | ||
) | ||
); | ||
} | ||
return Promise.resolve(validationResult); | ||
}, | ||
actionConnectorFields: null, | ||
actionParamsFields: lazy(() => import('./system_log_example_params')), | ||
isSystemActionType: true, | ||
}; | ||
} |
65 changes: 65 additions & 0 deletions
65
...ctions_ui_example/public/connector_types/system_log_example/system_log_example_params.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import React, { useEffect, useState } from 'react'; | ||
import { i18n } from '@kbn/i18n'; | ||
import type { ActionParamsProps } from '@kbn/triggers-actions-ui-plugin/public'; | ||
import { TextAreaWithMessageVariables } from '@kbn/triggers-actions-ui-plugin/public'; | ||
import { SystemLogActionParams } from '../types'; | ||
|
||
export const ServerLogParamsFields: React.FunctionComponent< | ||
ActionParamsProps<SystemLogActionParams> | ||
> = ({ | ||
actionParams, | ||
editAction, | ||
index, | ||
errors, | ||
messageVariables, | ||
defaultMessage, | ||
useDefaultMessage, | ||
}) => { | ||
const { message } = actionParams; | ||
|
||
const [[isUsingDefault, defaultMessageUsed], setDefaultMessageUsage] = useState< | ||
[boolean, string | undefined] | ||
>([false, defaultMessage]); | ||
// This params component is derived primarily from server_log_params.tsx, see that file and its | ||
// corresponding unit tests for details on functionality | ||
useEffect(() => { | ||
if ( | ||
useDefaultMessage || | ||
!actionParams?.message || | ||
(isUsingDefault && | ||
actionParams?.message === defaultMessageUsed && | ||
defaultMessageUsed !== defaultMessage) | ||
) { | ||
setDefaultMessageUsage([true, defaultMessage]); | ||
editAction('message', defaultMessage, index); | ||
} | ||
// eslint-disable-next-line react-hooks/exhaustive-deps | ||
}, [defaultMessage]); | ||
|
||
return ( | ||
<TextAreaWithMessageVariables | ||
index={index} | ||
editAction={editAction} | ||
messageVariables={messageVariables} | ||
paramsProperty={'message'} | ||
inputTargetValue={message} | ||
label={i18n.translate( | ||
'xpack.stackConnectors.components.systemLogExample.logMessageFieldLabel', | ||
{ | ||
defaultMessage: 'Message', | ||
} | ||
)} | ||
errors={errors.message as string[]} | ||
/> | ||
); | ||
}; | ||
|
||
// eslint-disable-next-line import/no-default-export | ||
export { ServerLogParamsFields as default }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 changes: 99 additions & 0 deletions
99
x-pack/examples/triggers_actions_ui_example/server/connector_types/system_log_example.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { i18n } from '@kbn/i18n'; | ||
import { schema, TypeOf } from '@kbn/config-schema'; | ||
|
||
import { LogMeta } from '@kbn/core/server'; | ||
import type { | ||
ActionType as ConnectorType, | ||
ActionTypeExecutorOptions as ConnectorTypeExecutorOptions, | ||
ActionTypeExecutorResult as ConnectorTypeExecutorResult, | ||
} from '@kbn/actions-plugin/server/types'; | ||
import { | ||
AlertingConnectorFeatureId, | ||
UptimeConnectorFeatureId, | ||
} from '@kbn/actions-plugin/common/connector_feature_config'; | ||
import { ConnectorAdapter } from '@kbn/alerting-plugin/server'; | ||
|
||
// see: https://en.wikipedia.org/wiki/Unicode_control_characters | ||
// but don't include tabs (0x09), they're fine | ||
const CONTROL_CHAR_PATTERN = /[\x00-\x08]|[\x0A-\x1F]|[\x7F-\x9F]|[\u2028-\u2029]/g; | ||
|
||
// replaces control characters in string with ;, but leaves tabs | ||
function withoutControlCharacters(s: string): string { | ||
return s.replace(CONTROL_CHAR_PATTERN, ';'); | ||
} | ||
|
||
export type ServerLogConnectorType = ConnectorType<{}, {}, ActionParamsType>; | ||
export type ServerLogConnectorTypeExecutorOptions = ConnectorTypeExecutorOptions< | ||
{}, | ||
{}, | ||
ActionParamsType | ||
>; | ||
|
||
// params definition | ||
|
||
export type ActionParamsType = TypeOf<typeof ParamsSchema>; | ||
|
||
const ParamsSchema = schema.object({ | ||
message: schema.string(), | ||
}); | ||
|
||
export const ConnectorTypeId = '.system-log-example'; | ||
// connector type definition | ||
export function getConnectorType(): ServerLogConnectorType { | ||
return { | ||
id: ConnectorTypeId, | ||
isSystemActionType: true, | ||
minimumLicenseRequired: 'gold', // Third party action types require at least gold | ||
name: i18n.translate('xpack.stackConnectors.systemLogExample.title', { | ||
defaultMessage: 'System log - example', | ||
}), | ||
supportedFeatureIds: [AlertingConnectorFeatureId, UptimeConnectorFeatureId], | ||
validate: { | ||
config: { schema: schema.object({}, { defaultValue: {} }) }, | ||
secrets: { schema: schema.object({}, { defaultValue: {} }) }, | ||
params: { | ||
schema: ParamsSchema, | ||
}, | ||
}, | ||
executor, | ||
}; | ||
} | ||
|
||
export const connectorAdapter: ConnectorAdapter = { | ||
connectorTypeId: ConnectorTypeId, | ||
ruleActionParamsSchema: ParamsSchema, | ||
buildActionParams: ({ alerts, rule, params, spaceId, ruleUrl }) => { | ||
return { ...params }; | ||
}, | ||
}; | ||
|
||
// action executor | ||
|
||
async function executor( | ||
execOptions: ServerLogConnectorTypeExecutorOptions | ||
): Promise<ConnectorTypeExecutorResult<void>> { | ||
const { actionId, params, logger } = execOptions; | ||
const sanitizedMessage = withoutControlCharacters(params.message); | ||
try { | ||
logger.info<LogMeta>(`SYSTEM ACTION EXAMPLE Server log: ${sanitizedMessage}`); | ||
} catch (err) { | ||
const message = i18n.translate('xpack.stackConnectors.serverLog.errorLoggingErrorMessage', { | ||
defaultMessage: 'error logging message', | ||
}); | ||
return { | ||
status: 'error', | ||
message, | ||
serviceMessage: err.message, | ||
actionId, | ||
}; | ||
} | ||
|
||
return { status: 'ok', actionId }; | ||
} |
13 changes: 13 additions & 0 deletions
13
x-pack/examples/triggers_actions_ui_example/server/index.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { PluginInitializer } from '@kbn/core/server'; | ||
|
||
export const plugin: PluginInitializer<void, void> = async () => { | ||
const { TriggersActionsUiExamplePlugin } = await import('./plugin'); | ||
return new TriggersActionsUiExamplePlugin(); | ||
}; |
33 changes: 33 additions & 0 deletions
33
x-pack/examples/triggers_actions_ui_example/server/plugin.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { Plugin, CoreSetup } from '@kbn/core/server'; | ||
|
||
import { PluginSetupContract as ActionsSetup } from '@kbn/actions-plugin/server'; | ||
import { PluginSetupContract as AlertingSetup } from '@kbn/alerting-plugin/server'; | ||
|
||
import { | ||
getConnectorType as getSystemLogExampleConnectorType, | ||
connectorAdapter as systemLogConnectorAdapter, | ||
} from './connector_types/system_log_example'; | ||
|
||
// this plugin's dependencies | ||
export interface TriggersActionsUiExampleDeps { | ||
alerting: AlertingSetup; | ||
actions: ActionsSetup; | ||
} | ||
export class TriggersActionsUiExamplePlugin | ||
implements Plugin<void, void, TriggersActionsUiExampleDeps> | ||
{ | ||
public setup(core: CoreSetup, { actions, alerting }: TriggersActionsUiExampleDeps) { | ||
actions.registerType(getSystemLogExampleConnectorType()); | ||
alerting.registerConnectorAdapter(systemLogConnectorAdapter); | ||
} | ||
|
||
public start() {} | ||
public stop() {} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know this is just an example, but is this intentionally set to
gold
? it's not a 3rd party action.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When registering the action type the
ensureSufficientLicense
inx-pack/plugins/actions/server/lib/ensure_sufficient_license.ts
will be thrown an error because only the.server-log
and the.index
are allowed to be on the basic license. What about leaving it as it is from now on and checking with @shanisagiv1 the minimum required license for system actions?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.