Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps] [POC] resolve conflicts when updating alert docs after rule execution #166038

Closed
wants to merge 2 commits into from

Conversation

pmuellr
Copy link
Member

@pmuellr pmuellr commented Sep 8, 2023

resolves: #158403

Summary

Current approach is to mget() the conflicting docs, to get their new OCC values (_seq_no, _primary_term) as well as "ad hoc" updated fields like case assignment, workflow status etc. Then re-try the bulk update.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 8, 2023

@pmuellr pmuellr changed the title [ResponseOps] resolve conflicts when updating alert docs after rule execution [ResponseOps] [POC] resolve conflicts when updating alert docs after rule execution Sep 8, 2023
@pmuellr
Copy link
Member Author

pmuellr commented Sep 12, 2023

closing, as I put the branch in the elastic repo, and want it in my own instead ...

@pmuellr pmuellr closed this Sep 12, 2023
@pmuellr pmuellr deleted the alerting/158403-alert-conflicts branch September 12, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Response Ops][Alerting] Discuss how to handle possible conflicts when updating alerts-as-data documents
3 participants