-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard navigation] Adds popout icon to links that open in new tab #165908
[Dashboard navigation] Adds popout icon to links that open in new tab #165908
Conversation
Pinging @elastic/kibana-presentation (Team:Presentation) |
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's some rendering issues in horizontal layout:
I would expect the text to be vertically centered with the external icon - right now, it's almost rendering like a superscript :) And perhaps we could reduce the space between the icon and the text a bit? (both in horizontal + vertical layouts). What do you think @andreadelrio?
Agreed. @nickpeihl take a look at how we handle the external link icon here to get an idea of that space and alignment we should be aiming for. |
d942688
to
7a3c8ef
Compare
Fixes #165771
Summary
Adds an extraAction button that renders a
popout
icon for Dashboard or URL links that open in a new tab. This is visually similar toEuiLink
with theexternal
prop. Unfortunately,EuiListGroupItem
does not support theexternal
prop so we add the icon as an extra action button. However,EuiListGroupItem
components do support truncating text and the extra action button appears regardless of the truncation.extra-actions-with-tooltip.mp4
truncated-with-tooltips.mp4
Note, the icon will not appear on Dashboard links that open in a new tab until elastic/eui#7159 is available in Kibana.EUI has been updated!