Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Unskips the by value lens tests #165798

Merged
merged 1 commit into from
Sep 6, 2023
Merged

[Dashboard] Unskips the by value lens tests #165798

merged 1 commit into from
Sep 6, 2023

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Sep 6, 2023 •
edited
Loading

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 6, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Security Investigations Cypress Tests #4 / Discover State "before each" hook for "should remember kql query when navigating away and back to discover " "before each" hook for "should remember kql query when navigating away and back to discover "
  • [job] [logs] Serverless Observability Tests / serverless common UI Data View Management Scripted fields tab is missing
  • [job] [logs] FTR Configs #24 / spaces api with security resolve copy to spaces conflicts superuser from the default space single-namespace types "before each" hook for "should return 200 when overwriting, with references"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula marked this pull request as ready for review September 6, 2023 11:40
@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Sep 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@stratoula stratoula added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Sep 6, 2023
ThomThomson
ThomThomson approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR results LGTM! Thank you for looking into this @stratoula!

@stratoula stratoula merged commit 66f4f9f into elastic:main Sep 6, 2023
@stratoula stratoula mentioned this pull request Sep 18, 2023
Merged
@stratoula
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

stratoula added a commit to stratoula/kibana that referenced this pull request Sep 18, 2023
@stratoula
[Dashboard] Unskips the by value lens tests (elastic#165798)
6e2c95a 
## Summary

Closes elastic#165461

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3069
--> 50 times

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3071
--> 100 times

### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 66f4f9f)
stratoula added a commit that referenced this pull request Sep 18, 2023
@stratoula
[8.10] [Dashboard] Unskips the by value lens tests (#165798) (#166625)
d88ae85 
# Backport

Closes #165461

This will backport the following commits from `main` to `8.10`:
- [[Dashboard] Unskips the by value lens tests
(#165798)](#165798)
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.11.0
Projects
None yet
Milestone
No milestone
5 participants
@stratoula @kibana-ci @elasticmachine @ThomThomson @kibanamachine