Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v88.2.0 #165790

Merged
merged 26 commits into from
Sep 12, 2023
Merged

Upgrade EUI to v88.2.0 #165790

merged 26 commits into from
Sep 12, 2023

Commits on Sep 6, 2023

  1. Upgrade EUI to v88.2.0

    cee-chen committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    b9a1247 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3bcc203 View commit details
    Browse the repository at this point in the history
  3. [Watcher] Convert .euiAccordionForm__title and `.euiAccordionForm__…

    …extraAction` to example custom CSS
    cee-chen committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    9295db7 View commit details
    Browse the repository at this point in the history
  4. [Security] Remove deprecated .euiAccordionForm__title

    - likely not important to preserve the text-decoration CSS here
    cee-chen committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    fe30ee8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    132f105 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f42bbed View commit details
    Browse the repository at this point in the history
  7. Update --euiFixedHeadersOffset dynamically based on Kibana chrome

    - include global banner if present, account for chrome visible or not
    
    + flatten conditional modifiers, to make overriding by other usages easier
    
    + remove offsets logic in _banner.scss, easier to handle it all in one place
    
    note: all flyouts/collapsible navs should inherit automatically from the `--euiFixedHeadersOffset` var
    cee-chen committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    836b111 View commit details
    Browse the repository at this point in the history
  8. Update Sass mixins to use CSS variables

    + delete unused `kibanaFullBodyMinHeight` mixin
    cee-chen committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    da3b2e5 View commit details
    Browse the repository at this point in the history
  9. Remove repeated constant declaration

    - by obtaining the height value from the DOM/CSS var
    cee-chen committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    9447496 View commit details
    Browse the repository at this point in the history
  10. Start dismantling kbnAffordForHeader mixin

    - Remove deprecated EUI mixin (now handled by CSS below)
    
    - Remove selector-specific overrides; update their usages to use the global CSS variable instead
    cee-chen committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    d929acb View commit details
    Browse the repository at this point in the history
  11. Fix solution sidebar nav sticky position

    - remove manual offset calculation and fall back to EuiPageSidebar's default inline styles instead, which automatically uses `--euiFixedHeadersOffset`
    
    + bonus: fix broken `:hover` effect on solution side navs by restoring missing className
    
    + continue dismantling `kbnAffordForHeader` mixin
    cee-chen committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    123ca2d View commit details
    Browse the repository at this point in the history
  12. Completely remove kbnAffordForHeader mixin

    + remove `kbnStickyMenu` entirely - it looks like old code and it's not clear to me exactly how that behavior is being used, or if it should be using EuiPageSidebar intead - will ping Fleet team to ask
    cee-chen committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    82af6db View commit details
    Browse the repository at this point in the history
  13. Remove need for kbnBody--projectLayout body class

    - # of fixed EuiHeaders should now be automatically detected and handled by EUI without needing any custom body logic
    cee-chen committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    c5d1e26 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    b5a8d27 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    695e246 View commit details
    Browse the repository at this point in the history
  16. [EuiHeader] Snapshot updates

    + some snapshot updates around the new header CSS var
    cee-chen committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    ebcd1fe View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    6617059 View commit details
    Browse the repository at this point in the history
  18. [Security] Fix timeline "flyout"

    - was relying on the old selectors to set the correct height - use the new EUI var instead and remove direct className reference
    cee-chen committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    daa279e View commit details
    Browse the repository at this point in the history
  19. [Lens] Remove unused euiFlyout className

    - className no longer has any direct styles applied, and as far as I can tell doesn't need any associated header-related flyout logic
    cee-chen committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    f7c3aac View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Configuration menu
    Copy the full SHA
    3e4611b View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Configuration menu
    Copy the full SHA
    42a4c01 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Configuration menu
    Copy the full SHA
    a8f074e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b530f22 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2e64389 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Configuration menu
    Copy the full SHA
    b7684cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9704de3 View commit details
    Browse the repository at this point in the history