-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs Explorer] Update DataGrid default preferences #165718
[Logs Explorer] Update DataGrid default preferences #165718
Conversation
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-only review, ROWS_HEIGHT_OPTIONS
changes LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach to define a few standard column sizes. 👍 But I wonder if it's really justified to use two different defaults for service.name
and host.name
. Intuitively their different widths looked "wrong" to me. 🤷 Can we really make any assumptions about their usual length?
I agree it looks kind of weird to have different sizes, but reserving a bigger space for both columns also seemed to leave less space for the |
@tonyghiani Doesn't the data grid provide decent auto sizing of the columns which we can utilize? Do we need to reserve a fixed width for the values? |
When adding new columns, if no configuration is provided for the specific Discover DataGrid component, the space is divided evenly for all the added columns. |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: |
📓 Summary
Closes #165482
Closes #165489
This PR apply new default preferences to the DataGrid for the Log Explorer:
service.name (240px)
andhost.name (320px)
fields. The column's width is taken by the average length of those specific fields.